Skip to content

Conversation

@jscissr
Copy link
Contributor

@jscissr jscissr commented Jan 16, 2016

The following files will no longer be installed with npm install buffer:

  • .npmignore
  • .travis.yml
  • .zuul.yml
  • test/**

This makes the install faster.

@nolanlawson
Copy link
Collaborator

I'm 👍, but gonna leave it to @feross to merge. Any potential issues with not including the LICENSE or README with the project?

@jscissr
Copy link
Contributor Author

jscissr commented Jan 16, 2016

These are automatically included: https://docs.npmjs.com/files/package.json#files

@nolanlawson
Copy link
Collaborator

Sweet!

@nolanlawson
Copy link
Collaborator

Apparently the "main" is installed by default (source)? If so, can we just do "files": []?

@jscissr
Copy link
Contributor Author

jscissr commented Jan 16, 2016

Yes, it works! 👍

@feross
Copy link
Owner

feross commented Feb 13, 2016

I personally don't think it's a good idea to ignore the test/ folder. That's documentation for the module that will now be missing when you're offline and need to look inside node_modules/buffer.

Ignoring huge test files is a good idea, but ignoring a few text files won't make a meaningful difference. npm install is primarily slow because of latency and roundtrips, in my experience. I don't think this is the right tradeoff.

Previous discussions:

nodejs/readable-stream#100
rvagg/through2#36
browserify/browserify#1093
browserify/sha.js#5
feross/string-to-stream#1
beatgammit/base64-js#16
mafintosh/csv-parser#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants