Skip to content

Don't set warnings as errors in Rust nightly builds in CI #1588

Closed
@bnjbvr

Description

@bnjbvr

... because then it means that you can get a new compilation failure unrelated to a PR, just because you compiled on a day where a new warning had been introduced in Rust-nightly.

For instance: https://github.com/bytecodealliance/wasmtime/pull/1578/checks?check_run_id=614733207 which I can't locally reproduce, even after upgrading to latest Rustc nightly (i suspect this is because i'm using RLS and all, and so it skipped updating as there was a missing rustup component).

cc @alexcrichton

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIncorrect behavior in the current implementation that needs fixing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions