Skip to content

Don't deny warnings on nightly CI #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Don't deny warnings on nightly CI #1589

merged 1 commit into from
Apr 24, 2020

Conversation

alexcrichton
Copy link
Member

Too much churn!

Closes #1588

@alexcrichton alexcrichton mentioned this pull request Apr 24, 2020
Closed
bnjbvr
bnjbvr approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexcrichton alexcrichton merged commit d1be0c1 into bytecodealliance:master Apr 24, 2020
@alexcrichton alexcrichton deleted the no-nightly-warnings branch April 24, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't set warnings as errors in Rust nightly builds in CI
2 participants
@alexcrichton @bnjbvr