Add a MinGW release to our CI #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends our CI to produce release artifacts for the x86_64-pc-windows-gnu target. This was originally motivate by the [go extension] where it looks like the Go toolchain primarily interoperates with MinGW, not with MSVC natively. The support here turned out to be quite trivial, largely just adding the configuration to make the release. I don't think we should necessarily commit to this being a primary platform for Wasmtime at this time though. If the support here regresses in the future for a difficult-to-fix reason I think it would be fine to back out the platform at least temporarily. Note that this does not add a full test suite for the MinGW target, only a release builder. This release builder does run tests, but not with full debug assertions enabled. [go extension]: bytecodealliance/wasmtime-go#3 Closes bytecodealliance#1535
fitzgen
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends our CI to produce release artifacts for the
x86_64-pc-windows-gnu target. This was originally motivate by the go
extension where it looks like the Go toolchain primarily interoperates
with MinGW, not with MSVC natively.
The support here turned out to be quite trivial, largely just adding the
configuration to make the release. I don't think we should necessarily
commit to this being a primary platform for Wasmtime at this time
though. If the support here regresses in the future for a
difficult-to-fix reason I think it would be fine to back out the
platform at least temporarily.
Note that this does not add a full test suite for the MinGW target, only
a release builder. This release builder does run tests, but not with
full debug assertions enabled.
Closes #1535