C# enable the runtime numbers test #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add features for the 2 dotnet runtime flavours, naot and mono
yowl
force-pushed
the
csharp-runtime-numbers
branch
from
8ebc6f8 to
dadf8ab
Compare
jsturtevant
reviewed
Nov 4, 2023
Comment on lines
+127
to
+129
| if cfg!(windows) { | ||
| c_sharp.push(path); | ||
| } |
There was a problem hiding this comment.
Question: When mono is added we will want to still add this for the linux case? Since we aren't running the tests on linux right now, is this needed?
There was a problem hiding this comment.
The problem is the yml matrix in build.yml tries to run all the OSes and if it creates the c# files then it will fail to compile them. Agree we will have to revisit this for Mono, not sure about MacOS, but for Linux we will want it.
Merged
Co-authored-by: James Sturtevant <[email protected]>
Co-authored-by: James Sturtevant <[email protected]>
…-bindgen into csharp-runtime-numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the first runtime test for c#.
It compiles using dotnet 8 and NativeAOT-LLVM which unfortunately requires clang from emscripten as well as the WASI SDK (see WebAssembly/wasi-sdk#326). So we download and install emscripten as well as dotnet 8. Tha NativeAOT-LLVM compiler is only supported on windows so the yml has the windows build separated out.
Dotnet 8 is required as we are using
static abstractinterface methods. This shouldn't be a major issue as dotnet 8 is coming out in a few weeks.Also moved some of the casting to the
Instructionemitcases.Added 2 new features,
csharp-naotandcsharp-monowhich bring incsharp.csharp-monohas no implementation here for the runtime test.