-
Notifications
You must be signed in to change notification settings - Fork 220
[csharp] Verify codegen #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Verify codegen #738
Conversation
Seems like the builds for dotnet take up lots of space 🤔 |
after doing a bit of clean up, getting real errors:
|
bba722e
to
57a0bff
Compare
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
57a0bff
to
216fc84
Compare
Yes, its unfortunate. Do we need to ask for more space? |
Signed-off-by: James Sturtevant <[email protected]>
The only option for getting more space is moving to the Enterprise or custom runners :-/ Interestingly it seems that some times we get a drive with 100GB+ and that's why it passed once. I think we have a few options:
|
I would very much recommend using |
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this will help a lot.
dir.join("nuget.config"), | ||
r#"<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<config> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is copied from the runtime version. I should have removed this really as I don't think there is much benefit and it may improve the CI time without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its fine though and we can address them both at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there a bit of duplicate code and this will become more challenging with a different project settings required for mono work. Let's follow up with a clean up?
The code gen is running but isn't being verified. This builds the source in the same way as the other languages.
It fixes the stub code so it uses the stub functions not just creating a class so that the code generated can compile. It also disables a few tests that are failing, to be fixed later
It uses the CI work enabled in #718, so will rebase after that is in.
Part of #713