[RaisedButton] Fix label validation for 0 (number data-type)#4285
Closed
mrdivyansh wants to merge 1 commit intomui:masterfrom
mrdivyansh:raisedBtnLabelValidationFix
Closed
[RaisedButton] Fix label validation for 0 (number data-type)#4285mrdivyansh wants to merge 1 commit intomui:masterfrom mrdivyansh:raisedBtnLabelValidationFix
mrdivyansh wants to merge 1 commit intomui:masterfrom
mrdivyansh:raisedBtnLabelValidationFix
Conversation
|
|
||
| function validateLabel(props, propName, componentName) { | ||
| if (!props.children && !props.label && !props.icon) { | ||
| if (!props.children && (!props.label && props.label !== 0) && !props.icon) { |
mbrookes
added
type: bug
Author
|
@mbrookes @oliviertassinari Any update ? |
Author
|
@oliviertassinari @mbrookes If PR is still not good, please could you do it by own. we need this fix on master branch as soon as possible. |
Member
|
Tested in this PR: #4346, specifically here: https://github.com/callemall/material-ui/pull/4346/files#diff-8cedf1e57ff556e069369f4f697bd932R131 Please open an issue if you believe this is still broken in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RaisedButton throw an error when label is zero (numeric data-type). This is special case, so we should handle it in validation function.