[FlatButton][RaisedButton] Fix label validation for 0 (number data-type)#4269
Closed
mrdivyansh wants to merge 2 commits intomui:masterfrom
mrdivyansh:labelValidationFix
Closed
[FlatButton][RaisedButton] Fix label validation for 0 (number data-type)#4269mrdivyansh wants to merge 2 commits intomui:masterfrom mrdivyansh:labelValidationFix
mrdivyansh wants to merge 2 commits intomui:masterfrom
mrdivyansh:labelValidationFix
Conversation
Member
|
@mrdivyansh Could you fix |
Author
|
@mbrookes PR ready :) |
mbrookes
changed the title
Member
|
Thanks, if you could just change the PR titles to: "[FlatButton] Fix label validation for 0 (number data-type)" and "[RaisedButton] Fix label validation for 0 (number data-type)" respectively, then we're good to go. Thanks! |
Author
Member
|
This one was fine. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatButton throw an error when label is zero (numeric data-type). This is special case, so we should handle it in validation function.