Skip to content

[DRAFT] Implement ApiDiff on top of the refactored GenAPI code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 125 commits into from
Closed

[DRAFT] Implement ApiDiff on top of the refactored GenAPI code #1

wants to merge 125 commits into from

Conversation

carlossanlop
Copy link
Owner

Currently targeting my branch to hide the GenAPI updates and only show the new feature.

After merging the other PR, I will either retarget this to dotnet/sdk main, or reopen a new one.

@ViktorHofer @ericstj

@carlossanlop carlossanlop mentioned this pull request Dec 18, 2024
Closed
v-wuzhai and others added 9 commits January 5, 2025 22:45
@v-wuzhai
Update the hardcoded tfm to the current
3be8ff4
@v-wuzhai
Update the corresponding tests
80fe749
@v-wuzhai
Use ToolsetInfo.CurrentTargetFramework in Aspire test
93cd030
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
405c63f 
…106.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
2dd724c 
…106.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sourcelink build 2…
6293b61 
…0250106.1

Microsoft.SourceBuild.Intermediate.sourcelink , Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab
 From Version 9.0.0-beta.24631.1 -> To Version 9.0.0-beta.25056.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
04fff54 
…106.3

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
a09b425 
…106.5

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
3b633ce 
…106.6

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.6
dotnet-maestro bot and others added 14 commits January 6, 2025 23:33
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
f781745 
…106.7

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
47270ca 
…106.8

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
3048c1c 
…106.21

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework
 From Version 4.13.0-3.25055.1 -> To Version 4.13.0-3.25056.21
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sourcelink build 2…
9bb7595 
…0250106.3

Microsoft.SourceBuild.Intermediate.sourcelink , Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab
 From Version 9.0.0-beta.24631.1 -> To Version 9.0.0-beta.25056.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
5d030c5 
…0250106.1

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 10.0.100-alpha.1.25055.1 -> To Version 10.0.100-alpha.1.25056.1
@v-wuzhai
Remove Skip attribute from tests related to issue dotnet#42850
c63afb2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
b57ac9b 
…0250106.2

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 10.0.100-alpha.1.25055.1 -> To Version 10.0.100-alpha.1.25056.2
@v-wuzhai
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…
faa291c 
…pdateTfm
@v-wuzhai
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/r…
a54746a 
…emove-skip-attribute-issue-42850
@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
6592d31 
…6.13.0.111

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.13.0-rc.108 -> To Version 6.13.0-rc.111
@nohwnd
Merge branch 'main' into nohwnd-patch-1
86dd8d3
@marcpopMSFT
Install the host rather than upgrading it
e5e2927 
Upgrading will cause rpm to fail if the item is already present like the host. This is how it works in the installer 8.0.1xx branch
@marcpopMSFT
Remove testsdkrpm entirely as it breaks because the host is already i…
1613483 
…nstalled. This was disabled in the 8.0 branches and this targets file was removed in main so just deleting the target entirely.
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202501…
322448d 
…06.4

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25056.3 -> To Version 9.0.0-preview.25056.4
dotnet-maestro bot and others added 25 commits January 9, 2025 22:23
@dotnet-maestro @ViktorHofer
[main] Update dependencies from dotnet/razor (dotnet#45804)
6dd4227 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
@mthalman
Revert VerticalManifest workaround (dotnet#45837)
03ea161
@dsplaisted
ApiDiff: Move ImplicitSymbolFilter from GenAPI.Filtering to ApiSymbol…
5367e4a 
…Exstensions.Filtering (dotnet#45806)
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
74880d3 
…250109.2

Microsoft.SourceBuild.Intermediate.vstest , Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.13.0-preview-25058-03 -> To Version 17.13.0-preview-25059-02
@mthalman
Remove TFM workaround for scenario tests (dotnet#45838)
eb04239
@dotnet-sb-bot
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25059.1 (dotnet#45840
e700c6e 
)
@Forgind
Merge branch 'main' into darc-main-2a75ff3e-4db2-45af-99ea-fc3c2a1398a2
abf6647
@dotnet-maestro
[main] Update dependencies from dotnet/windowsdesktop (dotnet#45819)
7b90c7f 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@Forgind
Merge branch 'main' into merge/release/9.0.2xx-to-main
ac30ec5
@mthalman
Enable SB stage 2 builds (dotnet#45791)
422fdd2
@v-wuzhai
Remove Skip attribute from tests related to issue dotnet#42850 (dotne…
1d3bf3b 
…t#45744)
@dotnet-maestro @lewing
[main] Update dependencies from dotnet/msbuild (dotnet#45812)
af492c4 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <[email protected]>
@v-wuzhai
[main] Update dependencies from microsoft/vstest (dotnet#45843)
7bd279e
@v-wuzhai
[main] Update dependencies from dotnet/templating (dotnet#45820)
b809d49
@v-wuzhai
[automated] Merge branch 'release/9.0.2xx' => 'main' (dotnet#45793)
fd53980
@mariam-abdulla @Evangelink
Use MSbuild APIs to Retrieve Projects Properties (dotnet#45724)
71aa100 
Co-authored-by: Amaury Levé <[email protected]>
@ViktorHofer
Use Windows scouting image in VMR to unblock builds (dotnet#45857)
6b3a36d
@dotnet-maestro @ViktorHofer
[main] Update dependencies from dotnet/windowsdesktop (dotnet#45853)
2d6bc4f 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
@dotnet-maestro @ViktorHofer
[main] Update dependencies from dotnet/msbuild (dotnet#45846)
16ccea5 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
@dotnet-maestro @Forgind @akoeplinger
[main] Update dependencies from microsoft/testfx (dotnet#45816)
900b930 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Forgind <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
@dotnet-maestro @ViktorHofer
[main] Update dependencies from dotnet/templating (dotnet#45858)
0a48572 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
@mthalman
Enable SB stage 2 builds in PR validation (dotnet#45865)
41bcaa9
@am11 @ViktorHofer
Add linux-riscv64 in ILCompilerSupportedRids (dotnet#45852)
f328251 
Co-authored-by: Viktor Hofer <[email protected]>
@dotnet-maestro
[main] Update dependencies from dotnet/source-build-reference-packages (
1e7127b 
dotnet#45813)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@carlossanlop
Pass an ILog instance to the AssemblySymbolLoader constructor.
e416b91 
Rename logger to log, use mock logger where needed.

Mock it all

AssemblySymbolLoader changes for warnings and diagnostics.

Author: Viktor Hofer <[email protected]>

Add TestLog class and use it to verify warnings in AssemblySymbolLoaderTests.

Apply suggestions from code review

Co-authored-by: Viktor Hofer <[email protected]>

Remove AssemblyReferenceNotFound compatibility differences in APICompat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.