Skip to content

[DRAFT] Implement ApiDiff on top of the refactored GenAPI code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 125 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
b4c1721
Add MSTest among common workloads
nohwnd Oct 30, 2024
a1f2384
Fix test
nohwnd Nov 6, 2024
57fdbb4
Merge branch 'main' into nohwnd-patch-1
nohwnd Nov 6, 2024
3be8ff4
Update the hardcoded tfm to the current
v-wuzhai Jan 6, 2025
80fe749
Update the corresponding tests
v-wuzhai Jan 6, 2025
93cd030
Use ToolsetInfo.CurrentTargetFramework in Aspire test
v-wuzhai Jan 6, 2025
405c63f
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
2dd724c
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
6293b61
Update dependencies from https://github.com/dotnet/sourcelink build 2…
dotnet-maestro[bot] Jan 6, 2025
04fff54
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
a09b425
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
3b633ce
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
f781745
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
47270ca
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 6, 2025
3048c1c
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 7, 2025
9bb7595
Update dependencies from https://github.com/dotnet/sourcelink build 2…
dotnet-maestro[bot] Jan 7, 2025
5d030c5
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 7, 2025
c63afb2
Remove Skip attribute from tests related to issue #42850
v-wuzhai Jan 7, 2025
b57ac9b
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 7, 2025
faa291c
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…
v-wuzhai Jan 7, 2025
a54746a
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/r…
v-wuzhai Jan 7, 2025
6592d31
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Jan 7, 2025
86dd8d3
Merge branch 'main' into nohwnd-patch-1
nohwnd Jan 7, 2025
e5e2927
Install the host rather than upgrading it
marcpopMSFT Jan 7, 2025
1613483
Remove testsdkrpm entirely as it breaks because the host is already i…
marcpopMSFT Jan 7, 2025
322448d
Update dependencies from https://github.com/dotnet/razor build 202501…
dotnet-maestro[bot] Jan 7, 2025
0a87b36
Update dependencies from https://github.com/dotnet/razor build 202501…
dotnet-maestro[bot] Jan 7, 2025
cf6faae
Remove the test rpm step as it's blocking builds and disabled in all …
marcpopMSFT Jan 7, 2025
72d0b4a
Update branding to 9.0.103
vseanreesermsft Jan 7, 2025
0f1d8b8
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 7, 2025
eec4c77
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
dotnet-maestro[bot] Jan 7, 2025
8b25057
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 7, 2025
be7d352
Merge branch 'main' into nohwnd-patch-1
Evangelink Jan 7, 2025
2f5d397
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
dotnet-maestro[bot] Jan 7, 2025
1b3a70f
Update branding to 9.0.103 (#45759)
marcpopMSFT Jan 7, 2025
2cba37e
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 8, 2025
9de44e8
Update the hardcoded tfm to the current (#45720)
v-wuzhai Jan 8, 2025
e979f25
[release/9.0.1xx] Update dependencies from dotnet/templating (#45773)
v-wuzhai Jan 8, 2025
eaadb9f
[main] Update dependencies from dotnet/windowsdesktop (#45763)
v-wuzhai Jan 8, 2025
caa2bf8
[main] Update dependencies from dotnet/razor (#45753)
v-wuzhai Jan 8, 2025
d93a38d
[main] Update dependencies from nuget/nuget.client (#45747)
v-wuzhai Jan 8, 2025
a028835
[main] Update dependencies from dotnet/templating (#45743)
v-wuzhai Jan 8, 2025
e7de18f
Merge branch 'release/9.0.2xx' of https://github.com/dotnet/sdk into …
v-wuzhai Jan 8, 2025
6d5299f
Update dependencies from https://github.com/dotnet/msbuild build 2025…
dotnet-maestro[bot] Jan 8, 2025
b90a146
Update dependencies from https://github.com/dotnet/sourcelink build 2…
dotnet-maestro[bot] Jan 8, 2025
4961836
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Jan 8, 2025
0d0a3ef
[release/9.0.2xx] Update dependencies from dotnet/razor (#45754)
v-wuzhai Jan 8, 2025
ffd4fa4
[release/9.0.2xx] Update dependencies from nuget/nuget.client (#45748)
dotnet-maestro[bot] Jan 8, 2025
5c42709
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 8, 2025
e006bf1
[main] Update dependencies from dotnet/sourcelink (#45730)
v-wuzhai Jan 8, 2025
cc5ecdc
fix tests on linux and macos hopefully
nohwnd Jan 8, 2025
b1e048f
dash
nohwnd Jan 8, 2025
0b0e820
Merge branch 'main' into nohwnd-patch-1
Evangelink Jan 8, 2025
afc8829
[release/9.0.2xx] Update dependencies from dotnet/roslyn (#45725)
v-wuzhai Jan 8, 2025
52c7b50
[main] Update dependencies from dotnet/roslyn (#45778)
v-wuzhai Jan 8, 2025
ba50f53
[main] Update dependencies from dotnet/msbuild (#45776)
v-wuzhai Jan 8, 2025
094238c
[main] Update dependencies from dotnet/templating (#45783)
v-wuzhai Jan 8, 2025
3431945
[automated] Merge branch 'release/9.0.1xx' => 'release/9.0.2xx' (#45771)
v-wuzhai Jan 8, 2025
50d3b55
whitespace
nohwnd Jan 8, 2025
eb25d4f
Merge branch 'nohwnd-patch-1' of https://github.com/dotnet/sdk into n…
nohwnd Jan 8, 2025
882a389
Merge branch 'main' of https://github.com/dotnet/sdk into nohwnd-patch-1
nohwnd Jan 8, 2025
cc260aa
Remove repo level SB legs in CI and PR validation (#45765)
MichaelSimons Jan 8, 2025
497de42
MSTest templates: drop unsupported TFMs from the list
Evangelink Jan 8, 2025
e874a21
Update VMR orchestrator dependencies
ViktorHofer Jan 8, 2025
d5fdbb1
Update VMR orchestrator dependencies (#45789)
ViktorHofer Jan 8, 2025
5faffec
Add posix dmp copy command (#45704)
Forgind Jan 8, 2025
42d7089
Add MSTest among common templates (#44523)
Evangelink Jan 8, 2025
7b0b368
[main] Update dependencies from dotnet/runtime (#45790)
dotnet-maestro[bot] Jan 8, 2025
ef91c4e
sln-remove: Support for slnx (#45160)
edvilme Jan 8, 2025
6d3569d
[main] Update dependencies from microsoft/vstest (#45794)
dotnet-maestro[bot] Jan 8, 2025
d2940a1
[release/9.0.2xx] Update dependencies from nuget/nuget.client (#45787)
dotnet-maestro[bot] Jan 8, 2025
7dc8f0b
[main] Update dependencies from nuget/nuget.client (#45786)
dotnet-maestro[bot] Jan 8, 2025
1edbc80
[main] Update dependencies from microsoft/testfx (#45780)
dotnet-maestro[bot] Jan 8, 2025
5966361
[main] Update dependencies from dotnet/aspnetcore (#45772)
dotnet-maestro[bot] Jan 8, 2025
36432e4
Update dependencies from https://github.com/dotnet/razor build 202501…
dotnet-maestro[bot] Jan 8, 2025
86e1a5e
Move ImplicitSymbolFilter from Microsoft.DotNet.GenAPI.Filtering to M…
carlossanlop Jan 8, 2025
7ba9bea
[main] Update dependencies from dotnet/windowsdesktop (#45782)
dotnet-maestro[bot] Jan 8, 2025
535f840
[main] Update dependencies from dotnet/arcade (#45777)
dotnet-maestro[bot] Jan 9, 2025
8fff72c
Update dependencies from https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 9, 2025
bee76bd
[release/9.0.2xx] Update dependencies from dotnet/razor (#45805)
v-wuzhai Jan 9, 2025
cda99cc
Merge branch 'main' into mstest-drop-unsupported
Evangelink Jan 9, 2025
cff7b34
Merge branch 'main' of https://github.com/dotnet/sdk into merge/relea…
v-wuzhai Jan 9, 2025
4107c9a
Use latest jdk available in VMR aspnetcore build (#45822)
ViktorHofer Jan 9, 2025
618fa80
Merge branch 'main' into mstest-drop-unsupported
Evangelink Jan 9, 2025
a0b6ebf
Small clean-up for infra that isn't necessary anymore in the VMR (#45…
ViktorHofer Jan 9, 2025
395a034
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25057.1 (#45749)
dotnet-sb-bot Jan 9, 2025
0bc759d
Make the SkipPrepareSdkArchive more useful for local dev innerloop (#…
ViktorHofer Jan 9, 2025
b07efa9
Add #nullable disable to files that don't yet use nullable annotation…
ViktorHofer Jan 9, 2025
d481f6c
Merge branch 'main' into ApiDiffPart3
carlossanlop Jan 9, 2025
0f031f6
Remove unused OverrideBootstrapVersions infrastructure (#45550)
MichaelSimons Jan 9, 2025
c21bb5b
Merge branch 'main' into mstest-drop-unsupported
Evangelink Jan 9, 2025
a84ed46
[main] Update dependencies from dotnet/arcade (#45823)
dotnet-maestro[bot] Jan 9, 2025
babe4bd
ApiDiff: Move TryGetRecordConstructor from GenAPI.INamedTypeSymbolExt…
carlossanlop Jan 9, 2025
42ec103
Merge branch 'main' into ApiDiffPart3
carlossanlop Jan 9, 2025
ae86a4a
ApiDiff: Allow deciding whether to include partial modifier in TypeDe…
carlossanlop Jan 9, 2025
da12057
[main] Update dependencies from dotnet/runtime (#45815)
dotnet-maestro[bot] Jan 9, 2025
0d4182f
Remove _OverrideArcadeInitializeBuildToolFramework env var in VMR rep…
ViktorHofer Jan 9, 2025
b3d6aca
MSTest templates: drop unsupported TFMs from the list (#45788)
Evangelink Jan 9, 2025
6dd4227
[main] Update dependencies from dotnet/razor (#45804)
dotnet-maestro[bot] Jan 9, 2025
03ea161
Revert VerticalManifest workaround (#45837)
mthalman Jan 9, 2025
5367e4a
ApiDiff: Move ImplicitSymbolFilter from GenAPI.Filtering to ApiSymbol…
dsplaisted Jan 9, 2025
74880d3
Update dependencies from https://github.com/microsoft/vstest build 20…
dotnet-maestro[bot] Jan 9, 2025
eb04239
Remove TFM workaround for scenario tests (#45838)
mthalman Jan 9, 2025
e700c6e
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.25059.1 (#45840)
dotnet-sb-bot Jan 9, 2025
abf6647
Merge branch 'main' into darc-main-2a75ff3e-4db2-45af-99ea-fc3c2a1398a2
Forgind Jan 10, 2025
7b90c7f
[main] Update dependencies from dotnet/windowsdesktop (#45819)
dotnet-maestro[bot] Jan 10, 2025
ac30ec5
Merge branch 'main' into merge/release/9.0.2xx-to-main
Forgind Jan 10, 2025
422fdd2
Enable SB stage 2 builds (#45791)
mthalman Jan 10, 2025
1d3bf3b
Remove Skip attribute from tests related to issue #42850 (#45744)
v-wuzhai Jan 10, 2025
af492c4
[main] Update dependencies from dotnet/msbuild (#45812)
dotnet-maestro[bot] Jan 10, 2025
7bd279e
[main] Update dependencies from microsoft/vstest (#45843)
v-wuzhai Jan 10, 2025
b809d49
[main] Update dependencies from dotnet/templating (#45820)
v-wuzhai Jan 10, 2025
fd53980
[automated] Merge branch 'release/9.0.2xx' => 'main' (#45793)
v-wuzhai Jan 10, 2025
71aa100
Use MSbuild APIs to Retrieve Projects Properties (#45724)
mariam-abdulla Jan 10, 2025
6b3a36d
Use Windows scouting image in VMR to unblock builds (#45857)
ViktorHofer Jan 10, 2025
2d6bc4f
[main] Update dependencies from dotnet/windowsdesktop (#45853)
dotnet-maestro[bot] Jan 10, 2025
16ccea5
[main] Update dependencies from dotnet/msbuild (#45846)
dotnet-maestro[bot] Jan 10, 2025
900b930
[main] Update dependencies from microsoft/testfx (#45816)
dotnet-maestro[bot] Jan 10, 2025
0a48572
[main] Update dependencies from dotnet/templating (#45858)
dotnet-maestro[bot] Jan 10, 2025
41bcaa9
Enable SB stage 2 builds in PR validation (#45865)
mthalman Jan 10, 2025
f328251
Add linux-riscv64 in ILCompilerSupportedRids (#45852)
am11 Jan 10, 2025
1e7127b
[main] Update dependencies from dotnet/source-build-reference-package…
dotnet-maestro[bot] Jan 10, 2025
e416b91
Pass an ILog instance to the AssemblySymbolLoader constructor.
carlossanlop Jan 9, 2025
aa7a626
genapirefactor
carlossanlop Jan 10, 2025
9b8d122
GenApiDiff
carlossanlop Jan 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .vsts-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -310,15 +310,6 @@ extends:
buildArchitecture: arm64
runtimeIdentifier: osx-arm64

############### SOURCE BUILD ###############
- template: /eng/common/templates-official/job/source-build.yml@self
parameters:
platform:
name: Managed
container: centosStream9
jobProperties:
timeoutInMinutes: 30

############### DOTNET-FORMAT ###############
- ${{ if or(eq(parameters.runTestBuild, true), eq(variables['Build.Reason'], 'PullRequest')) }}:
- template: /eng/dotnet-format/dotnet-format-integration.yml@self
Expand Down
9 changes: 0 additions & 9 deletions .vsts-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,5 @@ stages:
buildArchitecture: arm64
runtimeIdentifier: osx-arm64

############### SOURCE BUILD ###############
- template: /eng/common/templates/job/source-build.yml@self
parameters:
platform:
name: Managed
container: centosStream9
jobProperties:
timeoutInMinutes: 30

############### DOTNET-FORMAT ###############
- template: /eng/dotnet-format/dotnet-format-integration.yml
8 changes: 8 additions & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,18 @@

# Compatibility tools owned by runtime team
/src/Compatibility/ @dotnet/area-infrastructure-libraries
/src/Compatibility/Shared/ @dotnet/area-infrastructure-libraries

# Area-ApiCompat
/src/Compatibility/ApiCompat/ @dotnet/area-infrastructure-libraries
/test/Microsoft.DotNet.ApiCompatibility*/ @dotnet/area-infrastructure-libraries
/test/Microsoft.DotNet.ApiCompat*/ @dotnet/area-infrastructure-libraries
/test/Microsoft.DotNet.PackageValidation*/ @dotnet/area-infrastructure-libraries

# Area-ApiDiff
/src/Compatibility/ApiDiff/ @dotnet/area-infrastructure-libraries
/test/Microsoft.DotNet.ApiDiff.Tests/ @dotnet/area-infrastructure-libraries

# Area-GenAPI
/src/Compatibility/GenAPI/ @dotnet/area-infrastructure-libraries
/src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/ @dotnet/area-infrastructure-libraries
Expand Down
1 change: 1 addition & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Features" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="$(MicrosoftCodeAnalysisWorkspacesCommonPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="$(MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion)" />
<PackageVersion Include="Microsoft.Css.Parser" Version="$(MicrosoftCssParserVersion)" />
<PackageVersion Include="Microsoft.DiaSymReader" Version="$(MicrosoftDiaSymReaderVersion)" />
Expand Down
59 changes: 0 additions & 59 deletions eng/SourceBuildPrebuiltBaseline.xml

This file was deleted.

Loading