Skip to content

Referencing non-spec object or array crash #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cebe opened this issue Dec 2, 2019 · 0 comments · Fixed by #48
Closed

Referencing non-spec object or array crash #47

cebe opened this issue Dec 2, 2019 · 0 comments · Fixed by #48
Assignees
@cebe
Labels
bug Something isn't working
Milestone
1.3.2

Comments

@cebe
Copy link
Owner

cebe commented Dec 2, 2019

see thephpleague/openapi-psr7-validator#37, it should not assume object, array may also be returned: thephpleague/openapi-psr7-validator#37 (comment)
@cebe cebe added the bug Something isn't working label Dec 2, 2019
@cebe cebe added this to the 1.3.2 milestone Dec 2, 2019
@cebe cebe self-assigned this Dec 2, 2019
@cebe cebe mentioned this issue Dec 2, 2019
Closed
cebe added a commit that referenced this issue Dec 3, 2019
@cebe
Fix bug with referencing non-object types
e9521ee 
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47
@cebe cebe mentioned this issue Dec 3, 2019
Merged
cebe added a commit that referenced this issue Dec 4, 2019
@cebe
Fix bug with referencing non-object types
cc1a5d2 
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47
cebe added a commit that referenced this issue Dec 4, 2019
@cebe
Fix bug with referencing non-object types
e0cd761 
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47
@cebe cebe closed this as completed in #48 Dec 4, 2019
cebe added a commit that referenced this issue Dec 4, 2019
@cebe
Fix bug with referencing non-object types
fc0cee6 
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cebe cebe

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Fix bug with referencing non-object types cebe/php-openapi
1 participant
@cebe