Skip to content

Fix bug with referencing non-object types #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

cebe
Copy link
Owner

@cebe cebe commented Dec 3, 2019

a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47

@cebe cebe added the bug Something isn't working label Dec 3, 2019
@cebe cebe added this to the 1.3.2 milestone Dec 3, 2019
@cebe cebe force-pushed the fix-ref-non-objects branch from 9ee5be9 to d6785f3 Compare December 4, 2019 09:46
cebe added 2 commits December 4, 2019 11:37
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.

also creating references in non-object types and Type::ANY is working
correctly now.

fixes #47
@cebe cebe force-pushed the fix-ref-non-objects branch from d6785f3 to 3de06bf Compare December 4, 2019 10:37
@cebe cebe merged commit 7c1e7ef into master Dec 4, 2019
@cebe cebe deleted the fix-ref-non-objects branch December 4, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referencing non-spec object or array crash
1 participant