Skip to content

Support unwrapping unknown implementations of proto.Message#1207

Merged
TristonianJones merged 2 commits into
cel-expr:masterfrom
srikrsna:sk/fix-unwrap
Aug 18, 2025
Merged

Support unwrapping unknown implementations of proto.Message#1207
TristonianJones merged 2 commits into
cel-expr:masterfrom
srikrsna:sk/fix-unwrap

Conversation

@srikrsna

@srikrsna srikrsna commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

proto.Message can have implementations outside of protobuf module, all such cases should be treated as a dynamic message.

Signed-off-by: Sri Krishna <skrishna@buf.build>
@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

Comment thread common/types/pb/type.go
Signed-off-by: Sri Krishna <skrishna@buf.build>
@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit 8e7beb6 into cel-expr:master Aug 18, 2025
2 checks passed
renevo pushed a commit to Blizzard/cel-go that referenced this pull request Sep 12, 2025
…pr#1207)

* Support unwrapping unknown implementations of `proto.Message`

Signed-off-by: Sri Krishna <skrishna@buf.build>

* Add test case

Signed-off-by: Sri Krishna <skrishna@buf.build>

---------

Signed-off-by: Sri Krishna <skrishna@buf.build>
Co-authored-by: Sri Krishna <skrishna@buf.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants