Skip to content

Support unwrapping unknown implementations of proto.Message #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristonianJones merged 2 commits into from
Aug 18, 2025
+5 −1
Merged

Support unwrapping unknown implementations of proto.Message #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7566fa9
Support unwrapping unknown implementations of `proto.Message`
srikrsna-buf Aug 12, 2025
c5b883e
Add test case
srikrsna-buf Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/types/pb/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ func unwrap(desc description, msg proto.Message) (any, bool, error) {
}
return v.GetValue(), true, nil
}
return msg, false, nil
return unwrapDynamic(desc, msg.ProtoReflect())
Comment thread
TristonianJones marked this conversation as resolved.
}

// unwrapDynamic unwraps a reflected protobuf Message value.
Expand Down
4 changes: 4 additions & 0 deletions common/types/pb/type_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,10 @@ func TestTypeDescriptionMaybeUnwrap(t *testing.T) {
in: dpb.New(time.Duration(345)),
out: time.Duration(345),
},
{
in: struct{ proto.Message }{wrapperspb.Int32(1234)},
out: int32(1234),
},
}
for _, tc := range tests {
typeName := string(tc.in.ProtoReflect().Descriptor().FullName())
Expand Down