Skip to content

Move pch tests to a precompiled-headers subdirectory #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

kkjeer
Copy link
Contributor

@kkjeer kkjeer commented Nov 14, 2019

(See #719)
After introducing additional pch tests in #716, move the pch tests to their own precompiled-headers subdirectory.

Testing:

  • Passed manual testing on Windows.
  • Passed automated testing on Windows and Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang November 14, 2019 18:05
@mgrang
Copy link

mgrang commented Nov 14, 2019

LGTM.

Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kkjeer kkjeer merged commit fec2c12 into master Nov 14, 2019
@kkjeer kkjeer deleted the issue719-pch-tests-subdirectory branch November 14, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants