Skip to content

Add checked information for compound statements to AST reading/writing#716

Merged
kkjeer merged 3 commits into
masterfrom
issue419-read-write-compound-checked
Nov 6, 2019
Merged

Add checked information for compound statements to AST reading/writing#716
kkjeer merged 3 commits into
masterfrom
issue419-read-write-compound-checked

Conversation

@kkjeer

@kkjeer kkjeer commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

(Issue #419): Modify ASTWriterStmt and ASTReaderStmt to write/read the checked scope specifier and written checked scope specifier for compound statements.

Future work: add checked information for function declarations to ASTWriterDecl and ASTReaderDecl (see issue #704).

Testing:

  • Added pch testing that checks the AST output of compound statements with checked information (using the -ast-dump-all option to dump the AST of the precompiled header).
  • Passed local testing on Windows.
  • Passed automated testing on Windows/Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang November 5, 2019 00:34

@dtarditi dtarditi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The pch tests probably need to moved to a subdirectory. That can be done separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants