Merged
Conversation
Summary:
* Fix user signals and config so design boots with Caliptra ROM
* Unique AxUSER for Caliptra, MCU-LSU, and MCU-IFU
* Initialize data/bss/STACK to DCCM, as the MCU SRAM is locked at startup
Squashed commit of the following:
commit 76b1cc55bf7823fe89de652ddf7817e8a5b496e8
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Tue Mar 18 15:54:41 2025 -0700
Add comment for issue tracking
commit b495d1b85041110537dbfbce37cae45e9bb196b4
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Tue Mar 18 10:30:51 2025 -0700
Re-enable the AXI User fixes
commit ad38b48
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Tue Mar 18 10:28:22 2025 -0700
Hello world testcase that shows caliptra-core fw built from caliptra-ss repo
commit 62479b4
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Tue Mar 18 10:19:36 2025 -0700
Whitespace
commit 69611c4
Merge: 5ba71c4 a2a3cec
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 16:45:18 2025 -0700
Merge remote-tracking branch 'chips/main' into cwhitehead-msft-local-testcode-PoC
commit 5ba71c4
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 15:38:07 2025 -0700
Update testfile yml for all smoke tests
commit 8ef4e6f
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 13:52:51 2025 -0700
Roll back the USER/linker modifications to isolate just the methodology changes
commit 3500540
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 13:27:06 2025 -0700
Move mcu bringup tasks to shared lib file; update Makefile to init data to DCCM and build libs
commit 60ee631
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 12:03:27 2025 -0700
Reorganize the libs area
commit d40b3c6
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 11:21:18 2025 -0700
Rename top test list file
commit e6ba3ee
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 11:19:59 2025 -0700
Makefile cleanup
commit 384ed48
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:46:26 2025 -0700
Revert changes to mcu_hello_world -- it's a defunct test
commit 8fcfd45
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:42:53 2025 -0700
Add explanatory note/TODO on LSU user
commit 2e98c2d
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:35:39 2025 -0700
Update RTL submodule to pull fw_test_rom updates
commit 9ee216d
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:32:40 2025 -0700
Remove cptra AxUSER force; TMP: set cptra AxUSER as SOC CONFIG user
commit 5ff6e31
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:29:50 2025 -0700
Initialize data/bss/STACK to DCCM, as the MCU SRAM is locked at startup
commit 7b7181b
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:29:13 2025 -0700
Fixes to get cptra_ss_i3c_recovery pre-exec working
commit 6edb48a
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:28:13 2025 -0700
Unique AxUSER for Caliptra, MCU-LSU, and MCU-IFU
commit 33324b2
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Mon Mar 17 10:27:30 2025 -0700
Regenerate RDL files and update workflow to catch out of date RDL
commit 4aeedfc
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Fri Mar 14 12:03:55 2025 -0700
Use DEBUG_OUT as STDOUT in ss sims
commit 691f2f9
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 15:28:01 2025 -0700
Fix user signals and config so design boots with Caliptra ROM
commit 37b630c
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 14:57:22 2025 -0700
Add caliptra subsystem macro to compile.yml; update test-suites with plusargs/pre_exec
commit 41b423f
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 13:25:37 2025 -0700
Remove recipe for program.hex
commit eba6fd6
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 12:39:09 2025 -0700
Add a top-level include file that grabs all css ai3c tests
commit 6057cd3
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 12:38:42 2025 -0700
Rename ai3ct test as svh, since it's an include
commit a5a3651
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 13 12:36:59 2025 -0700
Reorganize ai3c tests
commit e058463
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 6 18:04:07 2025 -0800
Ending quote - syntax
commit 052f1e0
Author: Caleb Whitehead <cwhitehead@microsoft.com>
Date: Thu Mar 6 17:56:02 2025 -0800
Initial test code for bringup with local caliptra-core images
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the prim_generic OTP source from the fuse_ctrl configuration to the ss_tb integration configuration.
- In src/fuse_ctrl/config/compile.yml, the prim_generic_otp.sv file reference is commented out, indicating it is no longer directly used in the fuse_ctrl build.
- In src/integration/config/compile.yml, the prim_generic_otp.sv file is added to the testbench targets along with updated dependency entries.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/fuse_ctrl/config/compile.yml | Comments out prim_generic_otp.sv inclusion to reflect its removal from fuse_ctrl. |
| src/integration/config/compile.yml | Adds fuse_ctrl_pkg dependency and includes prim_generic_otp.sv in testbench. |
Files not reviewed (4)
- src/fuse_ctrl/rtl/otp_ctrl.sv: Language not supported
- src/fuse_ctrl/rtl/otp_ctrl_pkg.sv: Language not supported
- src/integration/rtl/caliptra_ss_top.sv: Language not supported
- src/integration/testbench/caliptra_ss_top_tb.sv: Language not supported
…' with updated timestamp and hash after successful run
bharatpillilli
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.