Skip to content

⚠️ CONFLICT! Lineage pull request for: skeleton#60

Merged
jsf9k merged 18 commits intodevelopfrom
lineage/skeleton
Mar 12, 2025
Merged

⚠️ CONFLICT! Lineage pull request for: skeleton#60
jsf9k merged 18 commits intodevelopfrom
lineage/skeleton

Conversation

@cisagovbot
Copy link
Copy Markdown

@cisagovbot cisagovbot commented Mar 6, 2025

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-ansible-role-with-test-user.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/ansible-role-cyhy-archive.git ansible-role-cyhy-archive
    cd ansible-role-cyhy-archive
    git remote add skeleton https://github.com/cisagov/skeleton-ansible-role-with-test-user.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add README.md molecule/default/converge.yml terraform/backend.tf terraform/providers.tf terraform/remote_states.tf terraform/user.tf 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • ✌️ The conflicts in this pull request have been resolved.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

dav3r and others added 12 commits March 4, 2025 15:03
This lets us avoid hardcoding the bucket name and allows it to be set on a per-environment basis via the -backend-config command line option or other methods.  For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
…emote states

Also, make all remote states use the same environment (no more mixed staging and production states).
.tfconfig is the extension we have chosen to use for our backend config files.
…-iam-user-tf-module

Also, replace an unused SSM parameter with a dummy value.
We plan to come up with a more comprehensive solution that will allow
testing in each environment, but we are not there yet.
Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
In many repos that inherit from this skeleton we need to specify a
bucket name where third-party installers, packages, licenses, etc. are
stored.  Previously we made this bucket name a role var with a default
value equal to the name of the bucket in our production COOL.  Now
we have multiple COOL environments, and we eventually want to test in
all environments to ensure that the third-party buckets in all
environments contain the expected objects.

Therefore, it no longer makes sense to use a default value for the
role variable.  Instead we lookup an environment variable in
converge.yml and have the GHA workflow set that variable when running
Molecule.

Co-authored-by: David Redmin <david.redmin@gwe.cisa.dhs.gov>
@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation terraform Pull requests that update Terraform code github-actions Pull requests that update GitHub Actions code labels Mar 7, 2025
@jsf9k jsf9k added this to CyHy System Mar 7, 2025
@jsf9k jsf9k force-pushed the lineage/skeleton branch from f4374b2 to 0f55951 Compare March 7, 2025 17:43
@jsf9k jsf9k merged commit c7e5cfa into develop Mar 12, 2025
13 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch March 12, 2025 14:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in CyHy System Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This issue or pull request improves or adds to documentation github-actions Pull requests that update GitHub Actions code terraform Pull requests that update Terraform code upstream update This issue or pull request pulls in upstream updates

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants