Merged
Conversation
These will stop Terraform from destroying and recreating these resources if they are simply being renamed.
jsf9k
added
improvement
dv4harr10
approved these changes
Mar 7, 2025
dav3r
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds
movedconfiguration blocks for resources that were simply renamed in #62.💭 Motivation and context
These will stop Terraform from destroying and recreating these resources if they are simply being renamed.
🧪 Testing
All automated tests pass. I also pointed the Terraform code in cisagov/ansible-role-cyhy-archive#60 to this branch and verified that it simply moved the resources. Without these changes that same Terraform code wanted to destroy and recreate the resources.
✅ Pre-approval checklist