Show eCapris statuses in Notes tab by mddilley · Pull Request #1615 · cityofaustin/atd-moped

mddilley · 2025-06-23T22:13:12Z

Associated issues

Closes cityofaustin/atd-data-tech#21794

This PR:

Updates the Notes tab to show eCAPRIS statuses if a project has an eCAPRIS subproject ID
Updates the three places to show the latest status update (from eCAPRIS if syncing is enabled and from Moped if syncing is disabled)
- Dashboard Following and My Projects tabs
- Project summary view

Testing

URL to test:

Local

Steps to test:

Go to https://localhost:3000/moped/projects/331
Follow this project and then add yourself to the team so you can see this project in the dashboard views later on
Go to the Notes tab and see that internal notes, status updates, and statuses synced from eCAPRIS can be viewed in the list. eCAPRIS statuses should show the content, author, and created at date and time just like Moped notes.
Switch the "Sync from eCAPRIS" toggle off and notice that the eCAPRIS statuses no longer show in the list (disabling the eCAPRIS filter button when eCAPRIS syncing is disabled is covered in Filter Notes tab to eCapris statuses only atd-data-tech#22702)
Switch the toggle back on and test filtering to the three note types. Hooray because this part came free! 🙌
Make sure that you cannot create a new eCAPRIS status update through the rich text editor
Now, go to the project summary and remove the eCAPRIS subproject id. It is 13240.027 just in case you lose it before the next step - I got you!
Go to the Notes tab and see that the eCAPRIS toggle is switched off and disabled to make sure that Rose's work didn't break
Go to the Funding table and add the eCAPRIS subproject id back in
Go to the Notes tab again and see that the eCAPRIS sync toggle is enabled and switched on again. You can try removing and adding from either the Summary or Funding tab to see the switch toggle off when an id is removed and on when an id is added.
Now, make sure you have a subproject id added and the syncing switch is on. Then, go to the Project summary. You should see the latest status update has "Unfunded for construction." at the end which is a status from eCAPRIS.
Go to Dashboard and check the rows for project 331 in the Following and My Projects tabs. You should see these also end with "Unfunded for construction."
Now, go back to the Notes tab and switch the eCAPRIS toggle off.
Go back to the project summary and Following and My Projects tabs to make sure that the status update shown does not have "Unfunded for construction." at the end. This is the latest status update added through Moped which is what we should see if syncing is disabled.

Ship list

Code reviewed
Product manager approved
Product manager checked DB view dependencies
~~[ ] Product manager added to QA test script if applicable~~

…or viewing and editing Moped notes

…ilter ecapris source

…tuses

…combined notes

…s expected shape instead

… in dashboard

…when eCAPRIS syncing is enabled/disabled

mddilley · 2025-06-24T21:38:53Z

        - id
        - name
        - slug
+        - source


this helps prevent rendering UI elements that are rendered from the rows in moped_note_types like the radio buttons in the rich text editor (source = ecapris).

mddilley · 2025-06-24T21:40:03Z

        - project_partners
        - project_sponsor
        - project_status_update
+        - project_status_update_author


This new view column lets us fetch status update authors through the project_list_view to show in the project summary page.

It is also why this PR needed the migration that I also used to update the name of eCAPRIS note types from "eCapris status update" to "Synced from eCAPRIS".

mddilley · 2025-06-24T21:44:44Z

+                // ProjectNotes will expect data to be passed in this shape with note type lookups
+                data={{
+                  moped_project: [row],
+                  moped_note_types: data.moped_note_types,
+                }}


This is awkward and doesn't feel great, but I found myself in a place where I either did this or break the way we used DashboardStatusModal in the project summary view. I decided to save any further refactoring for another day.

mddilley · 2025-06-24T21:45:32Z

Sorry for the large diff here. I found myself struggling to separate the note render from the rest of this component so I pulled it out into its own component.

I also moved all styles into sx props since we will one day need to fully migrate away from useStyles/makesStyles which is deprecated in new MUI versions.

roseeichelmann · 2025-06-30T19:14:34Z

+ * @param {Object} classes - The shared style settings
+ * @param {Object} data - The project data object from the GraphQL query
+ * @returns {JSX.Element}
+ */


roseeichelmann

this looks and works great mike!! i like that you pulled each ProjectNote into its own component ✨ 🚀 this was a huge chunk of work!!

johnclary

Wow—this looks great. All of the note interactions worked exactly as promised. It's so cool to see this in action!!! 🙌 🚢

johnclary · 2025-07-01T19:09:32Z

@@ -149,6 +138,9 @@ export const SUMMARY_QUERY = gql`
    project_list_view(where: { project_id: { _eq: $projectId } }) {


if i'm not mistaken, you no longer need this where condition because you added the manually-configured object relationship in the Hasura metadata 👀

ah yep! thanks for catching. I'll update here to make use of the object relationship too. 🙌

johnclary · 2025-07-01T19:09:46Z

+ * @param {Object} classes - The shared style settings
+ * @param {Object} data - The project data object from the GraphQL query
+ * @returns {JSX.Element}
+ */


johnclary · 2025-07-01T19:12:29Z

-    color: theme.palette.text.primary,
-  },
-}));
-


johnclary · 2025-07-01T19:16:48Z

-  // use currentPhaseId if passed down from ProjectSummaryStatusUpdate component,
-  // otherwise use data passed from ProjectView
+  /* User details for create and update mutations */
+  const userSessionData = getSessionDatabaseData();


looks like this call to local storage is firing on every keystroke when writing a status update. maybe a separate tech debt issue to turn this auth utility into a proper hook.

...or a quick useMemo wrapper around this call 😄

i am going to memo this - thanks for pointing out because now I can't unsee even though I probably scanned past it many times in this code. 🙏

also cityofaustin/atd-data-tech#23429

johnclary · 2025-07-01T20:11:48Z

+      displayNotes = displayNotes.filter(
+        (note) => note.note_type_slug !== "ecapris_status_update"
+      );
+    }


Just my two cents, but it might be helpful to persist this helper text about sync frequency somewhere on the screen when syncing is enabled so that all users are aware of that cadence. E.g. read-only users or non-project managers might not hover over that toggle very often 🤔

This is a good point, and the frequency does feel very hidden away when I'm looking at this now. I'll bring an alternative to refinement today for some feedback. I think that reaching for FormHelperText could be a nice improvement. Thanks!

…_filter Disable eCAPRIS Notes Filter

… text when switched on

mddilley and others added 27 commits June 12, 2025 13:49

Add TODOs

d7b0aab

Repalce notes query with combined notes query and update references f…

628f32c

…or viewing and editing Moped notes

Update summary query with note type source; use in radio buttons to f…

74ad148

…ilter ecapris source

Update notes query conditions to handle showing ecapris statuses

5139868

Create a component out of the project note JSX

3404aff

Remove some styles and replace with sx

5a6b3cf

Remove last class

4364842

Fix broken note filtering

b9e9595

Add comments and group some of the code

9369c67

Fix user edit bug; update note edit/delete buttons to not overlap

a920356

Merge branch 'mike/22270_notes_view' into mike/21794_show_ecapris_sta…

e8fb7c2

…tuses

Remove unneeded is_deleted filter; updates query with correct view name

6a91d31

Use note type id for setting note type and filtering

11817bc

Pull in toggle code

456b5e4

Merge branch 'mike/22270_notes_view' into mike/21794_show_ecapris_sta…

c3605a6

…tuses

Add migrations to show latest status update author in plv

d63afd6

Update ProjectNotes, DashboardStatusModal, and DashboardView to show …

873477a

…combined notes

Revert changes to ProjectNotes and update DashboardStatusModal to pas…

163ef51

…s expected shape instead

Fix bad merge of styles and toggle

a937ee0

Remove note requests from dashboard queries; fix status update filter…

e25c142

… in dashboard

Update summary to show latest update from project_list_view

4f8ddaf

Update ProjectNotes to handle when to show status updates (modal) or …

0cffd09

…when eCAPRIS syncing is enabled/disabled

Fix delete by using correct id reference

259ed1d

Add sync status field to project part of dashboard query

48dab0e

Add style back to restore dashboard status update pointer cursor

17be147

Update ecapris note type name

8c178ec

🤖 Export view for 21794_show_ecapris_statuses

dd3ea42

mddilley added the WIP Work in progress label Jun 23, 2025

mddilley mentioned this pull request Jun 23, 2025

Filter Notes tab to eCapris statuses only cityofaustin/atd-data-tech#22702

Closed

mddilley commented Jun 24, 2025

View reviewed changes

Update var that I somehow named worse

2a780f8

mddilley removed the WIP Work in progress label Jun 24, 2025

mddilley requested review from chiaberry, frankhereford, johnclary, mateoclarke, roseeichelmann and tillyw June 24, 2025 22:17

roseeichelmann reviewed Jun 30, 2025

View reviewed changes

roseeichelmann approved these changes Jun 30, 2025

View reviewed changes

roseeichelmann added 4 commits June 30, 2025 15:38

pass disable ecapris filter prop

78df2da

disable when there is no syncing, render tooltip

5c0567e

update var name

6fa3e6b

add to docstring

f0004df

johnclary approved these changes Jul 1, 2025

View reviewed changes

roseeichelmann and others added 5 commits July 2, 2025 11:55

Add comment explaining tooltip span

30c8a34

Merge pull request #1620 from cityofaustin/rose/22702_disable_ecapris…

5cf0b7b

…_filter Disable eCAPRIS Notes Filter

Update project summary query to use plv object relationship

c2f0794

Memo userSessionData; update tooltip to show when disabled and helper…

013bf1b

… text when switched on

Remove TODOs

265d315

mddilley merged commit da7137d into mike/22270_notes_view Jul 2, 2025

mddilley deleted the mike/21794_show_ecapris_statuses branch July 2, 2025 22:05

		@@ -149,6 +138,9 @@ export const SUMMARY_QUERY = gql`
		project_list_view(where: { project_id: { _eq: $projectId } }) {

Conversation

mddilley commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Associated issues

Testing

Ship list

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roseeichelmann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mddilley Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mddilley commented Jun 23, 2025 •

edited

Loading

mddilley Jun 24, 2025 •

edited

Loading

mddilley Jun 24, 2025 •

edited

Loading

mddilley Jun 24, 2025 •

edited

Loading

roseeichelmann left a comment •

edited

Loading

mddilley Jul 2, 2025 •

edited

Loading

johnclary Jul 1, 2025 •

edited

Loading