Add eCAPRIS funding sync UI and update funding buttons#1730
Conversation
✅ Deploy Preview for atd-moped-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chiaberry
requested review from
frankhereford,
johnclary,
mateoclarke,
mddilley,
roseeichelmann and
tillyw
mddilley
left a comment
mddilley
left a comment
There was a problem hiding this comment.
So cool to see this come to life! 🙌 I requested one change, but I'd like backup on it since it has to do with accessibility so I'm approving. This works great! 🚀🚀🚀
| }) | ||
| .then(() => { | ||
| handleSnackbar(true, "eCAPRIS sync status updated", "success"); | ||
| refetchFundingData(); |
There was a problem hiding this comment.
awesome, this will work great to get the right combo of Moped & eCAPRIS rows into this table. 🙏 🎉
There was a problem hiding this comment.
I am seeing a bit of jumping/flashing in the UI after I flip the switch. my best guess is that the two queries that are called by refetchFundingData are resolving at different times. Maybe they could be awaited together to fix that?
There was a problem hiding this comment.
glad this looked yucky to you too! 😆 i'm hoping that cityofaustin/atd-data-tech#26043 will resolve this since DataGridPro has a nicer row loading state prop that we can use to avoid the flashing and shifting caused by the current spinner that blocks the entire table UI.
But, I just added to the feature release testing in #1734 to prevent it from sliding by.
chiaberry
changed the title
| if (loadingProjectFunding || loadingFduOptions || !dataProjectFunding) | ||
| return <CircularProgress />; | ||
|
|
||
| console.log(dataProjectFunding) |
There was a problem hiding this comment.
this snuck back in there after I fixed some merge conflicts I bet
| }) | ||
| .then(() => { | ||
| handleSnackbar(true, "eCAPRIS sync status updated", "success"); | ||
| refetchFundingData(); |
There was a problem hiding this comment.
I am seeing a bit of jumping/flashing in the UI after I flip the switch. my best guess is that the two queries that are called by refetchFundingData are resolving at different times. Maybe they could be awaited together to fix that?
roseeichelmann
left a comment
roseeichelmann
left a comment
There was a problem hiding this comment.
this works good! i also noticed the jumpiness that john pointed out when you flip the switch
4 participants
Associated issues
cityofaustin/atd-data-tech#24673
cityofaustin/atd-data-tech#23248
Testing
URL to test:
Test locally since there are metadata changes.
Steps to test:
Using production data,
hasura metadata applyGet your DB client ready
Navigate to a project without an eCAPRIS ID, ex: https://localhost:3000/moped/projects/3645.
Switch to the funding tab. You should see two buttons and a switch, since there is no eCAPRIS ID, the switch and button are disabled. Hover over the switch and see the tooltip informing you why it is disabled.
Now choose a project with an eCAPRIS ID (or add one to a project). The buttons are active and the switch is as well.
Check in the db client the status of
should_sync_ecapris_fundingToggle the switch, and then run the sql again. Confirm that the switch matches the status of
should_sync_ecapris_fundingShip list
[ ] Product manager added to QA test script if applicable