fix: TransformWithStruct/DefaultNameTransformer change for invalid column names #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 47.04% 47.05%
=======================================
Files 76 76
Lines 7858 7861 +3
=======================================
+ Hits 3697 3699 +2
- Misses 3670 3671 +1
Partials 491 491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
⏱️ Benchmark resultsComparing with e9f29ff
|
hermanschaaf
approved these changes
Apr 25, 2023
yevgenypats
approved these changes
Apr 26, 2023
candiduslynx
pushed a commit
that referenced
this pull request
Apr 28, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-04-28) ### Features * Add table description to Arrow schema metadata ([#824](#824)) ([1a8072f](1a8072f)) * **arrow:** Streamline Apache Arrow extension types ([#823](#823)) ([f32fac3](f32fac3)) * **test:** Add double migration test ([#827](#827)) ([4cd3872](4cd3872)) * Time values are truncated uniformly ([#825](#825)) ([ffb97b0](ffb97b0)) ### Bug Fixes * TransformWithStruct/DefaultNameTransformer change for invalid column names ([#820](#820)) ([01e6649](01e6649)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cloudquery/cloudquery#10274
I went for the simple approach of not accepting the json tag value if it's going to result in an invalid column name.