feat: Time values are truncated uniformly #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with 4cd3872
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
- Coverage 47.19% 46.98% -0.22%
==========================================
Files 76 76
Lines 7844 7873 +29
==========================================
- Hits 3702 3699 -3
- Misses 3642 3683 +41
+ Partials 500 491 -9
☔ View full report in Codecov by Sentry. |
|
Could also be done in the CLI: cloudquery/cloudquery#10365 |
Agreed, but the issue still exists for anyone that doesn't upgrade their CLI... This way as long as they can update their destination and be safe |
disq
reviewed
Apr 26, 2023
disq
approved these changes
Apr 26, 2023
hermanschaaf
approved these changes
Apr 27, 2023
yevgenypats
approved these changes
Apr 27, 2023
candiduslynx
pushed a commit
that referenced
this pull request
Apr 28, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-04-28) ### Features * Add table description to Arrow schema metadata ([#824](#824)) ([1a8072f](1a8072f)) * **arrow:** Streamline Apache Arrow extension types ([#823](#823)) ([f32fac3](f32fac3)) * **test:** Add double migration test ([#827](#827)) ([4cd3872](4cd3872)) * Time values are truncated uniformly ([#825](#825)) ([ffb97b0](ffb97b0)) ### Bug Fixes * TransformWithStruct/DefaultNameTransformer change for invalid column names ([#820](#820)) ([01e6649](01e6649)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure time values are truncated uniformly across all operating systems and in line with the arrow casting