Remove "Enterprise" from v25.2 cdc docs and deprecate experimental changefeed syntax #19680
+172
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
katmayb
force-pushed
the
sinkless-changefeeds-experimental
branch
from
7ea7580 to
3ecea93
Compare
rmloveland
approved these changes
Jun 4, 2025
| @@ -41,8 +39,6 @@ Before you run the examples, verify that you have the `CHANGEFEED` privilege in | |||
|
|
|||
| In this example, you'll set up a changefeed for a single-node cluster that is connected to a Kafka sink. The changefeed will watch two tables. | |||
|
|
|||
| 1. If you do not already have one, [request a trial {{ site.data.products.enterprise }} license]({% link {{ page.version.version }}/licensing-faqs.md %}#obtain-a-license). | |||
| toc: true | ||
| docs_area: stream_data | ||
| --- | ||
|
|
||
| Core and {{ site.data.products.enterprise }} changefeeds offer different levels of configurability. {{ site.data.products.enterprise }} changefeeds allow for active changefeed jobs to be [paused](#pause), [resumed](#resume), and [canceled](#cancel). | ||
| Changefeeds offer different levels of configurability. Changefeeds emitting to a sink allow for active changefeed jobs to be [paused](#pause), [resumed](#resume), and [canceled](#cancel). Sinkless changefeeds streams changes directly to the SQL session. |
There was a problem hiding this comment.
nit: double plural, i think this could read "Sinkless changefeeds stream changes ..."
| @@ -53,46 +53,39 @@ For further detail on performance-related configuration, refer to the [Advanced | |||
| - After you [restore from a full-cluster backup]({% link {{ page.version.version }}/restore.md %}#full-cluster), changefeed jobs will **not** resume on the new cluster. It is necessary to manually create the changefeeds following the full-cluster restore. | |||
| - {% include {{ page.version.version }}/cdc/virtual-computed-column-cdc.md %} | |||
|
|
|||
| The following Enterprise and Core sections outline how to create and configure each type of changefeed: | |||
| The following sections outline how to create and configure each type of changefeed: | |||
There was a problem hiding this comment.
this is why i no longer ever say a number of anything, only ever "the following things ..." 🤣
There was a problem hiding this comment.
YES, ever since you mentioned this to me in another review, I'm trying to remove those where I notice. And "either"
katmayb
commented
Jun 4, 2025
|
TFTRs! |
katmayb
force-pushed
the
sinkless-changefeeds-experimental
branch
from
edb015f to
2144a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to ensure "Enterprise" is removed from cdc docs — this is only for v25.2 (most of the changes are mechanical)
Deprecates
EXPERIMENTAL CHANGEFEED FOR. PromotesCREATE CHANGEFEEDwithout sink syntax as our "sinkless" changefeed product option.Part of DOC-13882 (PR 1 of 3)