Skip to content

Remove 'Enterprise' mentions from v25.1 docs + rename 'basic' to 'sinkless changefeeds' #19718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

katmayb
Copy link
Contributor

@katmayb katmayb commented Jun 5, 2025

This PR relates to the work to complete DOC-13882.

Removes "Enterprise" and "Basic" from the v25.1 changefeed docs. Renames 'basic' changefeeds to 'sinkless'.

Other than the deprecation of experimental changefeed for in #19680, this PR is mechanically the same but for v25.1.

Bonus: forgot to call out the v25.2 deprecation of experimental changefeed for syntax within the v25.2 GA release notes in #19680, so I've added to this PR.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit b9bcf9b
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6846e59ae0e51b0008c7e2de

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit b9bcf9b
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6846e59a1213440008c77f29

Copy link

netlify bot commented Jun 5, 2025

Netlify Preview

Name Link
🔨 Latest commit b9bcf9b
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6846e59a7c9df300080475b7
😎 Deploy Preview https://deploy-preview-19718--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jun 5, 2025

Files changed:

@katmayb katmayb requested a review from rmloveland June 5, 2025 20:41
@katmayb
Copy link
Contributor Author

katmayb commented Jun 5, 2025

@rmloveland, fyi this is mostly the same as the 25.2 PR you just reviewed, I noted the differences in the PR description.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! THANK YOU !!!!!!!

@katmayb katmayb force-pushed the cdc-sinkless-enterprise-25.1 branch from a5c8e54 to 184f2ce Compare June 6, 2025 16:29
@katmayb katmayb merged commit d65f812 into main Jun 9, 2025
6 checks passed
@katmayb katmayb deleted the cdc-sinkless-enterprise-25.1 branch June 9, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants