forked from demisto/content
-
Notifications
You must be signed in to change notification settings - Fork 0
Code42/update py42 dep #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timabrmsn
reviewed
Sep 3, 2020
version: -1 | ||
name: What type of hash was supplied? | ||
description: Check whether the values provided in arguments are equal. If either | ||
of the arguments are missing, no is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "none is returned"?
timabrmsn
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any obvious issues, with limited XSOAR experience that I have...
antazoey
pushed a commit
that referenced
this pull request
Oct 6, 2020
* [code42-363] Add Else to Download File playbook and upgrade docker file (demisto#8814) * Current file * Add fetch + new commands to test playbook * Delete unused pb * corrections * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * [code42-636] Bump py42 dependency docker container (demisto#8257) * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs * [code42-636] Improve documentation examples (demisto#8305) * Remove whitespace in yml * Gen yml * Main * Tags * Handle unsupported ets better * Fix comment * Gen yml * New fields * Update views * Handle test command better * Gen yml * Adjust comment * lint * gen yml * savE * Test outputs * Use test id * move and use file events mapping * Create details widget * Save * Add params * Add results param * Fix hr add desc * Handle list risk tags for 2 cmds{ * Update descs * Handle none possibilities for dict gets * Current file * Add fetch + new commands to test playbook * Delete unused pb * corrections * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> * Use mapping * Update docker container * Reuse code and renames * Test source code case * bumped docker version * Fix test * Release notes (#32) * Update release notes * CL * Copy cl entry to rn * Remove unused method * Delete tmp file * Code42/update py42 dep (#34) * Update docker tag * Use FileCategory constants * Use Detection List filter constants * Update release notes * Update release notes * Format playbook * Correct release notes * Remove unneeded s from release notes, typo * Handle lowercase pdf * Handle all cases better * Handle all the cases * Remove commented out code * Lessen coment * Update release notes * Rm extra space in release notes * Put else statement on correct Task Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]> * Update 2_0_4.md * Update 2_0_4.md Co-authored-by: Juliya Smith <[email protected]> Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]> Co-authored-by: roysagi <[email protected]>
antazoey
pushed a commit
that referenced
this pull request
Nov 16, 2020
demisto#9432) * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * [code42-636] Bump py42 dependency docker container (demisto#8257) * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs * [code42-636] Improve documentation examples (demisto#8305) * Remove whitespace in yml * Gen yml * Main * Tags * Handle unsupported ets better * Fix comment * Gen yml * New fields * Update views * Handle test command better * Gen yml * Adjust comment * lint * gen yml * savE * Test outputs * Use test id * move and use file events mapping * Create details widget * Save * Add params * Add results param * Fix hr add desc * Handle list risk tags for 2 cmds{ * Update descs * Handle none possibilities for dict gets * Current file * Add fetch + new commands to test playbook * Delete unused pb * corrections * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> * Use mapping * Update docker container * Reuse code and renames * Test source code case * bumped docker version * Fix test * Release notes (#32) * Update release notes * CL * Copy cl entry to rn * Remove unused method * Delete tmp file * Code42/update py42 dep (#34) * Update docker tag * Use FileCategory constants * Use Detection List filter constants * Update release notes * Update release notes * Format playbook * Correct release notes * Remove unneeded s from release notes, typo * Handle lowercase pdf * Handle all cases better * Handle all the cases * Remove commented out code * Lessen coment * Update release notes * Rm extra space in release notes * Put else statement on correct Task * Rm using statements * Bump docker image * Update release data * Undo merge mistakes * apply PR feedback: * Bump docker version * Fix vers in release notes Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]> Co-authored-by: Juliya Smith <[email protected]> Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XSOAR Partner?
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Demisto
Does it break backward compatibility?
Must have