-
Notifications
You must be signed in to change notification settings - Fork 0
V9.0.4/service update #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update revises package dependencies to newer versions, updates the nginx base image in the Dockerfile, advances reusable workflow references to version 2, and refreshes test environment Docker tags. Documentation files, including release notes and changelog, are updated to reflect these changes. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD Pipeline
participant Docker
participant TestRunner
Developer->>CI/CD Pipeline: Pushes code with updated dependencies and configs
CI/CD Pipeline->>Docker: Builds with nginx:1.28.0-alpine
CI/CD Pipeline->>TestRunner: Runs tests using updated test runner image
CI/CD Pipeline-->>Developer: Reports build and test results
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.docfx/Dockerfile.docfx (1)
1-1
: Remove leading BOM from Dockerfile.
There's a byte order mark (BOM) at the start which can interfere with Docker parsing. Remove it to prevent potential build failures.CHANGELOG.md (1)
10-12
: Changelog entry is consistent.
The new## [9.0.4] - 2025-06-16
entry matches the existing format. Consider adding a GitHub compare link for quick reference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.docfx/Dockerfile.docfx
(2 hunks).github/workflows/pipelines.yml
(3 hunks).nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt
(1 hunks)CHANGELOG.md
(1 hunks)Directory.Packages.props
(1 hunks)testenvironments.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
🔇 Additional comments (7)
.docfx/Dockerfile.docfx (1)
1-1
: NGINX image update looks good.
You’ve upgraded both the base and final stages tonginx:1.28.0-alpine
. Ensure this tag is available on Docker Hub and compatible with your configuration.Also applies to: 11-11
Directory.Packages.props (1)
6-9
: Verify updated package versions.
Patch versions forCodebelt.Extensions.Xunit.App
,Cuemon.AspNetCore.Authentication
,Cuemon.Security.Cryptography
,Microsoft.NET.Test.Sdk
, andxunit.runner.visualstudio
have been bumped. Confirm these releases exist on NuGet and that your CI/tests pass with them.Also applies to: 15-15
testenvironments.json (1)
12-12
: Test environment image updated.
UpdatedDocker-Ubuntu
togimlichael/ubuntu-testrunner:net8.0.411-9.0.301
. Verify this image is published and contains all required dependencies for your test suite..nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt (1)
1-5
: Release notes update looks accurate.
The entry for version 9.0.4 correctly reflects dependency upgrades and TFM availability, aligning with the changelog. Ensure consistent phrasing across all supported TFMs..github/workflows/pipelines.yml (3)
30-30
: Request verification for build job upgrade
The build job now points tocodebeltnet/jobs-dotnet-build@v2
. Please confirm that v2 retains compatibility with the existing inputs (configuration
,strong-name-key-filename
).
42-42
: Request verification for pack job upgrade
The pack job was bumped tocodebeltnet/jobs-dotnet-pack@v2
and theupload-packed-artifact
input was removed. Verify that artifact packaging and publishing still function as expected.
55-55
: Request verification for test job upgrade
The test job now referencescodebeltnet/jobs-dotnet-test@v2
. Ensure thatruns-on
,configuration
, andbuild-switches
inputs are fully supported in v2.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 86 86
Branches 2 2
=========================================
Hits 86 86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request includes updates to dependencies, workflows, and Docker configurations to ensure compatibility with the latest versions and improve maintainability. The most important changes include upgrading Docker images and dependencies, updating GitHub Actions workflows, and documenting the changes in release notes and changelogs.
Dependency Updates:
.docfx/Dockerfile.docfx
: Upgraded the base and final Docker images fromnginx:1.27.5-alpine
tonginx:1.28.0-alpine
. [1] [2]Directory.Packages.props
: Updated multiple package versions, includingCodebelt.Extensions.Xunit.App
(10.0.1 → 10.0.3),Cuemon.AspNetCore.Authentication
(9.0.5 → 9.0.6), andMicrosoft.NET.Test.Sdk
(17.14.0 → 17.14.1).testenvironments.json
: Updated the Docker image for the test environment togimlichael/ubuntu-testrunner:net8.0.411-9.0.301
.Workflow Updates:
.github/workflows/pipelines.yml
: Updated GitHub Actions workflows (jobs-dotnet-build
,jobs-dotnet-pack
, andjobs-dotnet-test
) to use versionv2
instead ofv1
. Removed theupload-packed-artifact
parameter from thejobs-dotnet-pack
workflow. [1] [2] [3]Documentation Updates:
.nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt
: Added release notes for version 9.0.4, highlighting upgraded dependencies for all supported target frameworks.CHANGELOG.md
: Documented version 9.0.4 as a service update focused on package dependencies.Summary by CodeRabbit