-
Notifications
You must be signed in to change notification settings - Fork 0
V9.0.1/package maintenance #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request represents a comprehensive update to the project, focusing on upgrading to .NET 9.0, updating package dependencies, and extending the copyright year from 2024 to 2025. The changes span multiple configuration files, including Dockerfile, DocFX configuration, package release notes, changelog, build properties, and test environment settings. The update aims to modernize the project's infrastructure, align with the latest .NET framework, and maintain consistent versioning across different components. Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt (1)
4-5
: Consider simplifying the ALM note.The phrase "with respect to TFMs" could be simplified to "for TFMs" or "across TFMs" for better readability.
-# ALM -- CHANGED Dependencies to latest and greatest with respect to TFMs +# ALM +- CHANGED Dependencies to latest and greatest across TFMs🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability...(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
README.md (1)
9-10
: Improve Markdown formatting while maintaining documentation link.Great addition of the documentation link! However, let's improve the Markdown formatting to follow best practices.
Apply this diff to wrap the URL in angle brackets:
-Full documentation (generated by [DocFx](https://github.com/dotnet/docfx)) located here: https://awssignature4.codebelt.net/ +Full documentation (generated by [DocFx](https://github.com/dotnet/docfx)) located here: <https://awssignature4.codebelt.net/>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
9-9: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.docfx/Dockerfile.docfx
(1 hunks).docfx/docfx.json
(2 hunks).nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt
(1 hunks)CHANGELOG.md
(1 hunks)Directory.Build.props
(1 hunks)Directory.Packages.props
(1 hunks)LICENSE
(1 hunks)README.md
(1 hunks)testenvironments.json
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- LICENSE
- .docfx/Dockerfile.docfx
- testenvironments.json
- CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
.nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
🪛 markdownlint-cli2 (0.17.2)
README.md
9-9: Bare URL used
null
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: 🧪 Test (ubuntu-22.04, Release)
- GitHub Check: 📦 Pack (Release)
- GitHub Check: 🧪 Test (ubuntu-22.04, Debug)
- GitHub Check: 📦 Pack (Debug)
🔇 Additional comments (5)
Directory.Packages.props (2)
6-8
: LGTM! Package updates align with PR objectives.The patch updates to Codebelt packages (9.0.0 -> 9.0.1) are consistent with the maintenance nature of this PR.
9-15
: Verify compatibility of test package updates.Notable changes:
- xunit.runner.visualstudio: Major version bump (2.8.2 -> 3.0.1)
- Microsoft.NET.Test.Sdk: Minor version update (17.11.1 -> 17.12.0)
Run this script to check for any breaking changes or compatibility issues:
Directory.Build.props (1)
19-19
: LGTM! Copyright year update is consistent.The copyright year update to "2024-2025" aligns with similar updates across other files in this PR.
.nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt (1)
1-2
: LGTM! Version and framework support are correctly documented.The new version entry (9.0.1) and framework support (.NET 9 and .NET 8) align with the package updates.
.docfx/docfx.json (1)
15-15
: LGTM! Framework and copyright updates are consistent.The changes align with the PR objectives:
- TargetFramework update to net9.0
- Copyright year update to 2024-2025
Also applies to: 48-48
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 86 86
Branches 2 2
=========================================
Hits 86 86 ☔ View full report in Codecov by Sentry. |
|
This pull request includes various updates, mainly focusing on version upgrades and minor improvements across multiple files. The most important changes include updates to the Dockerfile, target framework, package versions, and copyright.
Version upgrades and updates:
.docfx/Dockerfile.docfx
: Updated the base image fromnginx:1.27.0-alpine
tonginx:1.27.3-alpine
..docfx/docfx.json
: Changed theTargetFramework
fromnet8.0
tonet9.0
.Directory.Packages.props
: Updated several package versions, includingCodebelt.Extensions.Xunit.App
,Cuemon.AspNetCore.Authentication
, andCuemon.Security.Cryptography
to9.0.1
, andMicrosoft.NET.Test.Sdk
to17.12.0
.Documentation and metadata updates:
.nuget/Codebelt.Extensions.AwsSignature4/PackageReleaseNotes.txt
: Added release notes for version9.0.1
, highlighting availability for .NET 9 and .NET 8 and changes to dependencies.README.md
: Added a link to the full documentation generated by DocFx.Copyright:
LICENSE
: Updated the copyright year from 2024 to 2024-2025.Directory.Build.props
: Updated the copyright year similarly.These updates ensure the project stays current with the latest dependencies and frameworks, and improve the overall documentation and metadata.
Summary by CodeRabbit
Release Notes for Version 9.0.1
New Features
Package Updates
Documentation
Infrastructure