-
Notifications
You must be signed in to change notification settings - Fork 0
V9.0.4/service update #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update increments several package dependencies to newer versions, updates the nginx base image in the Dockerfile, refreshes test environment Docker image tags, and revises the CI workflow to use newer reusable workflow versions. Documentation files are updated to reflect these changes, including release notes and changelog entries. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD Pipeline
participant Docker
participant Test Environment
Developer->>CI/CD Pipeline: Push changes (package, Dockerfile, workflow updates)
CI/CD Pipeline->>Docker: Build with nginx:1.28.0-alpine
CI/CD Pipeline->>Test Environment: Use updated gimlichael/ubuntu-testrunner image
CI/CD Pipeline->>CI/CD Pipeline: Run build, pack, test jobs (using v2 workflows)
CI/CD Pipeline-->>Developer: Report results and artifacts
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 11 11
Lines 237 237
Branches 9 9
=======================================
Hits 201 201
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pipelines.yml (1)
62-62
: Enable dependency restore in test job
Addingrestore: true
ensures assets are pre-restored. Optionally, consider integrating NuGet caching for faster rebuilds across runs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.docfx/Dockerfile.docfx
(2 hunks).github/workflows/pipelines.yml
(3 hunks).nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt
(1 hunks)CHANGELOG.md
(1 hunks)Directory.Packages.props
(1 hunks)testenvironments.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-pack (Debug) / 📦 Pack
🔇 Additional comments (17)
.docfx/Dockerfile.docfx (2)
1-1
: Update NGINX base image version
Bumping tonginx:1.28.0-alpine
aligns with the latest patch release. Please confirm that any custom modules or configuration snippets remain compatible with the new version.
11-11
: Update NGINX final image version
The final stage now also usesnginx:1.28.0-alpine
. Ensure this image’s security CVEs have been vetted and that performance characteristics meet your requirements.CHANGELOG.md (1)
10-12
: Add v9.0.4 changelog entry
The new entry follows the Keep a Changelog format and matches prior version sections.testenvironments.json (1)
12-12
: Update Docker-Ubuntu test image tag
Switched togimlichael/ubuntu-testrunner:net8.0.411-9.0.301
. Please verify that this image is published and contains the expected .NET SDK/runtime versions..nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt (2)
1-2
: Introduce release notes for v9.0.4
The Version and Availability lines are consistent with prior entries.
5-5
: Document upgraded dependencies
The ALM section accurately reflects that all TFMs have had their dependencies bumped to current compatible versions..github/workflows/pipelines.yml (3)
30-30
: Upgrade build workflow reference to v2
Switching tojobs-dotnet-build@v2
is appropriate. Verify that v2 preserves the outputs (version
) and secrets mapping from v1.
44-44
: Upgrade pack workflow reference to v2
Thejobs-dotnet-pack@v2
call is updated. Ensure the removal of theupload-packed-artifact
input aligns with the new workflow’s defaults.
57-57
: Upgrade test workflow reference to v2
Thejobs-dotnet-test@v2
update is in place. Confirm that v2’s defaults still execute tests across the matrix as expected.Directory.Packages.props (8)
6-6
: Verify the Bootstrapper.Web version bump to 4.0.1
Ensure that upgradingCodebelt.Bootstrapper.Web
from its previous version doesn’t introduce breaking changes in your startup configuration or DI setup.
7-7
: ConfirmAsp.Versioning
upgrade to 9.0.4 compatibility
The new release may include API surface changes—verify all versioning attributes and middleware registrations still compile and behave as expected.
8-8
: ValidateXunit.App
update to 10.0.3
Upgrading the test App package can affect custom test discoverers or runners—run the full test suite to confirm no regressions.
9-9
: Check JSON formatter package bump to 9.0.6
Cuemon.Extensions.AspNetCore.Mvc.Formatters.Text.Json
changes could alter default serialization settings—review controllers relying on custom JSON options.
10-10
: EnsureMicrosoft.AspNetCore.OpenApi
9.0.6 works with existing OpenAPI config
This upgrade may adjust how the OpenAPI middleware generates docs—validate your Swagger endpoints render correctly.
11-11
: VerifyMicrosoft.NET.Test.Sdk
move to 17.14.1
A new test SDK version can change discovery or execution—confirm CI pipelines still detect and execute all tests.
13-13
: ReviewSwashbuckle.AspNetCore
update to 9.0.1
Check for any breaking changes in the Swagger generator or UI setup that require startup adjustments.
18-18
: Validatexunit.runner.visualstudio
upgrade to 3.1.1
Ensure the Visual Studio test adapter still loads correctly and reports results in your CI environment.
This pull request includes updates to dependencies, workflows, and Docker configurations to ensure compatibility with the latest versions and improve functionality. Key changes include upgrading Docker images, updating workflow actions, and bumping package versions to address dependency updates.
Dependency Updates:
Directory.Packages.props
: Updated multiple package versions, includingCodebelt.Extensions.Asp.Versioning
to9.0.4
,Swashbuckle.AspNetCore
to9.0.1
, and others to their latest compatible versions..nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt
: Added release notes for version9.0.4
, highlighting dependency upgrades across all supported target frameworks.CHANGELOG.md
: Added a new entry for version9.0.4
, emphasizing the focus on package dependency updates.Workflow Updates:
.github/workflows/pipelines.yml
: Updated actions for build, pack, and test jobs from versionv1
tov2
. Addedrestore: true
in the test job configuration for improved workflow execution. [1] [2] [3]Docker Configuration Updates:
.docfx/Dockerfile.docfx
: Upgraded the base and final Docker images fromnginx:1.27.5-alpine
tonginx:1.28.0-alpine
. [1] [2]testenvironments.json
: Updated the Docker image for the test environment togimlichael/ubuntu-testrunner:net8.0.411-9.0.301
.Summary by CodeRabbit