V9.0.7/service update #14
Conversation
WalkthroughUpdates version tags across configuration files: NGINX base image in .docfx Dockerfile, centralized NuGet package versions, test runner Docker image, and corresponding changelog and package release notes entries for version 9.0.7. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
CHANGELOG.md (1)
10-12: Add availability line for consistency with release notes.Consider adding “Availability: .NET 9 and .NET 8” under 9.0.7 to mirror PackageReleaseNotes formatting and keep docs aligned.
## [9.0.7] - 2025-09-15 +Availability: .NET 9 and .NET 8 + This is a service update that focuses on package dependencies..docfx/Dockerfile.docfx (2)
1-17: Base stage cleanup is unused; final stage doesn’t inherit from base.The HTML cleanup in the base stage never applies to the final image. Either inherit final from base or move the cleanup to final.
-FROM nginx:${NGINX_VERSION} AS final +FROM base AS final WORKDIR /usr/share/nginx/html COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html
8-11: Prefer COPY over ADD; reduce context and pin image by digest.Small hardening/efficiency tweaks.
-ADD [".", "docfx"] +COPY . docfxAdditional:
- Add a .dockerignore to avoid copying unnecessary files into the build context.
- Pin nginx:${NGINX_VERSION} and codebeltnet/docfx:2.78.3 by digest for reproducibility.
- Optionally run as non-root in final (e.g., USER nginx) if feasible for your hosting.
.nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt (1)
7-12: Resolve duplication/inconsistency with 9.0.6 entry.If the intent is to relocate “Dependencies upgraded” to 9.0.7, remove the ALM block from 9.0.6 here to avoid conflicting messages with CHANGELOG.
Version 9.0.6 Availability: .NET 9 and .NET 8 -# ALM -- CHANGED Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs) +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.docfx/Dockerfile.docfx(1 hunks).nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(1 hunks)testenvironments.json(1 hunks)
🔇 Additional comments (4)
.nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt (1)
1-6: LGTM: Clear 9.0.7 note.Directory.Packages.props (2)
13-13: Consider pinning Swashbuckle/OpenAPI minors together across repos.Not a blocker; just ensure any consumers relying on generated OpenAPI docs are validated against Swashbuckle.AspNetCore 9.0.4 + Microsoft.AspNetCore.OpenApi 9.0.9 combination.
6-10: LGTM — central package versions verified; no per-project Version overrides found. Directory.Packages.props enables ManagePackageVersionsCentrally and lists the updated versions; project files contain PackageReference entries without Version attributes, so the central versions will be applied.testenvironments.json (1)
12-12: Ensure .NET SDK versions match testenvironments.json image (8.0.414 & 9.0.305).
No global.json found in the repo — add/update global.json or pin CI job SDKs to 8.0.414 and 9.0.305 to match testenvironments.json dockerImage "gimlichael/ubuntu-testrunner:net8.0.414-9.0.305" (File: testenvironments.json, line 12).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 11 11
Lines 237 237
Branches 9 9
=======================================
Hits 201 201
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
This pull request is a service update focused on upgrading package dependencies to their latest compatible versions across the project. The changes ensure improved compatibility, stability, and support for .NET 9 and .NET 8 environments.
Dependency Upgrades:
Directory.Packages.props, includingCodebelt.Bootstrapper.Web,Codebelt.Extensions.Asp.Versioning,Codebelt.Extensions.Xunit.App,Cuemon.Extensions.AspNetCore.Mvc.Formatters.Text.Json,Microsoft.AspNetCore.OpenApi, andSwashbuckle.AspNetCoreto their latest releases.testenvironments.jsonto use a newer base image version for the Ubuntu test runner, improving environment consistency..docfx/Dockerfile.docfxto1.29.1-alpinefor improved security and stability.Documentation Updates:
.nuget/Codebelt.Extensions.Swashbuckle.AspNetCore/PackageReleaseNotes.txt, highlighting the dependency upgrades and supported .NET versions.CHANGELOG.mdto include the new 9.0.7 release, describing the focus on package dependency updates.Summary by CodeRabbit
Documentation
Chores