V9.0.5/service update #15
Conversation
WalkthroughThis update introduces a build argument for the nginx version in the DocFX Dockerfile, updates several dependency and test environment versions, upgrades workflow job references to newer versions, and adds release notes for package updates. The changelog is updated to reflect a new service release focused on dependency maintenance. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.docfx/Dockerfile.docfx (1)
1-3: Good param-etization; consider pinning by digest for reproducible builds
Introducing theNGINX_VERSIONARG removes hard-coded tags – nice. To make builds deterministic and safer against supply-chain attacks, pin the image to a tag + digest instead of tag-only, e.g.-FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION} AS base +FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION}@sha256=<digest> AS base(Same for the
finalstage.)CHANGELOG.md (1)
10-13: Add comparison link to keep-a-changelog footer
Previous versions include only prose; adding a link such as[9.0.5]: https://github.com/<org>/<repo>/compare/v9.0.4...v9.0.5keeps the changelog navigable and consistent with the Keep a Changelog spec.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.docfx/Dockerfile.docfx(2 hunks).github/workflows/pipelines.yml(2 hunks).nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(1 hunks)testenvironments.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
🔇 Additional comments (8)
testenvironments.json (1)
12-12: LGTM! Test environment Docker image updated appropriately.The Docker image tag update from
net8.0.411-9.0.301tonet8.0.412-9.0.302aligns with the dependency upgrade objectives for this service update..nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt (1)
1-6: LGTM! Release notes properly formatted and consistent.The new version 9.0.5 entry follows the established format and accurately reflects the dependency upgrade changes for this service update.
Directory.Packages.props (1)
6-15: LGTM! Package versions updated consistently.All dependency updates are minor/patch version bumps that maintain compatibility while incorporating the latest fixes and improvements. The updates align with the service update objectives.
.nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt (1)
1-6: LGTM! Release notes consistent across packages.The new version 9.0.5 entry is properly formatted and maintains consistency with the corresponding changes in related package release notes.
.github/workflows/pipelines.yml (1)
68-68: LGTM! CI workflow references updated to v2.The updates to
codebeltnet/jobs-sonarcloudandcodebeltnet/jobs-codeqlfrom@v1to@v2are consistent and align with the CI workflow enhancement objectives. Note that thecodecovjob (line 78) remains at@v1, which appears to be intentional.Also applies to: 86-86
.docfx/Dockerfile.docfx (1)
13-17: Double-check that$BUILDPLATFORMis respected in the final stage
Because the finalFROMno longer specifies--platform=$BUILDPLATFORM, Docker will default to the builder’s host platform. If multi-arch artefacts are important in your CI, consider:-FROM nginx:${NGINX_VERSION} AS final +FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION} AS finalOtherwise cross-platform builds may silently produce host-specific images.
.nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt (1)
1-6: Release notes look good
Entry is concise and aligns with earlier format..nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt (1)
1-6: Release notes look good
No issues spotted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 17 17
Lines 611 611
Branches 57 57
=======================================
Hits 540 540
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
This pull request introduces updates to dependencies, Docker configurations, and CI workflows, along with minor adjustments to release notes and testing environments. The most critical changes focus on upgrading dependencies to ensure compatibility and stability, updating Docker images for improved performance, and enhancing CI workflows.
Dependency Updates:
Directory.Packages.props. This includes upgrades forCodebelt.Extensions.Xunit,Cuemon.AspNetCore, and others.Docker Configuration:
.docfx/Dockerfile.docfxto use an argument for the NGINX version (NGINX_VERSION=1.29.0-alpine) and updated the base and final images accordingly. [1] [2]CI Workflow Enhancements:
.github/workflows/pipelines.ymlto use versionv2ofcodebeltnet/jobs-sonarcloudandcodebeltnet/jobs-codeqlfor improved functionality. [1] [2]Release Notes:
9.0.5in multiple files, highlighting upgraded dependencies and availability for.NET 9and.NET 8. [1] [2] [3] [4]9.0.5inCHANGELOG.md, emphasizing dependency updates.Testing Environment:
testenvironments.jsontogimlichael/ubuntu-testrunner:net8.0.412-9.0.302.Summary by CodeRabbit