V9.0.1/package maintenance #11
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces significant updates to the project's infrastructure and dependencies, primarily focusing on version increments and compatibility with .NET 9. Changes include updating the Nginx base image, modifying the target framework in configuration files, incrementing package versions, and adjusting copyright years. Additionally, support for .NET 6 has been removed across various components, while new Docker image versions and release notes have been updated to reflect these changes. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
Directory.Build.props (1)
Remove orphaned source link configuration or restore the package
The source link configuration properties are present but ineffective without the Microsoft.SourceLink.GitHub package. This creates misleading configuration as the properties suggest source link functionality that isn't actually available. Either:
- Remove the orphaned properties (EmbedUntrackedSources, PublishRepositoryUrl, IncludeSymbols, SymbolPackageFormat)
- Or restore the Microsoft.SourceLink.GitHub package to enable the intended functionality
🔗 Analysis chain
Line range hint
18-40: Verify impact of removing Microsoft.SourceLink.GitHub.The Microsoft.SourceLink.GitHub package has been removed, but the following properties are still present:
- EmbedUntrackedSources
- PublishRepositoryUrl
- IncludeSymbols
- SymbolPackageFormat
Please verify if source link functionality is still required.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for source link configuration and usage # Check if any other source link packages are referenced rg -l "Microsoft.SourceLink" --type props --type csproj # Verify if source link is still enabled in build output find . -name "*.snupkg" -o -name "*.symbols.nupkg" | while read pkg; do echo "Checking source link in $pkg" dotnet symbol verify "$pkg" || true doneLength of output: 149
Script:
#!/bin/bash # Search for any SourceLink related packages and configurations rg -l "Microsoft\.SourceLink|SourceLink" --type-add 'props:*.props' --type-add 'csproj:*.csproj' --type props --type csproj # Check for any package references that might be related to source linking rg -l "PackageReference.*Source" --type-add 'props:*.props' --type-add 'csproj:*.csproj' --type props --type csproj # Look for any source debugging related configurations rg "(EmbedUntrackedSources|PublishRepositoryUrl|IncludeSymbols|SymbolPackageFormat)" --type-add 'props:*.props' --type-add 'csproj:*.csproj' --type props --type csproj -A 1 -B 1Length of output: 1371
🧹 Nitpick comments (2)
.nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt (1)
1-5: Consider simplifying the dependency update note.The version and availability information is correct, but consider simplifying "with respect to TFMs" to "for supported frameworks" or simply "across frameworks" for better readability.
-CHANGED Dependencies to latest and greatest with respect to TFMs +CHANGED Dependencies to latest and greatest across frameworks🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt (1)
4-5: Consider simplifying the ALM change description.The phrase "with respect to TFMs" could be more concise.
-- CHANGED Dependencies to latest and greatest with respect to TFMs ++ CHANGED Dependencies to latest versions for all TFMs🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.docfx/Dockerfile.docfx(1 hunks).docfx/docfx.json(2 hunks).nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Build.props(1 hunks)Directory.Build.targets(0 hunks)Directory.Packages.props(1 hunks)LICENSE(1 hunks)testenvironments.json(1 hunks)
💤 Files with no reviewable changes (1)
- Directory.Build.targets
✅ Files skipped from review due to trivial changes (3)
- LICENSE
- .docfx/Dockerfile.docfx
- testenvironments.json
🧰 Additional context used
🪛 LanguageTool
.nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: 🛠️ Build (Release, net8.0)
- GitHub Check: 🛠️ Build (Release, net9.0)
🔇 Additional comments (9)
Directory.Packages.props (2)
6-15: LGTM! Consistent version updates across packages.All Codebelt and Cuemon packages have been consistently updated to version 9.0.1, maintaining version alignment across the ecosystem.
22-24: Verify compatibility with xunit major version update.The xunit.runner.visualstudio package has been updated to 3.0.1, which is a major version bump. While the changes look good, please ensure compatibility with the test suite.
✅ Verification successful
The xunit.runner.visualstudio 3.0.1 update is compatible with the current setup ✅
The version difference between xunit core (2.9.3) and VS runner (3.0.1) is normal and safe, as the Visual Studio test runner is decoupled from the core xunit version. The codebase uses high-level test abstractions via Codebelt.Extensions.Xunit packages and doesn't directly interact with runner APIs.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any breaking changes in xunit.runner.visualstudio v3.0.1 # Search for xunit runner usage patterns that might be affected rg -l "ITestRunner|TestRunner|RunnerSettings" --type cs # Check release notes for breaking changes curl -s "https://raw.githubusercontent.com/xunit/visualstudio.xunit/v3.0.1/CHANGELOG.md"Length of output: 161
Script:
#!/bin/bash # Find test projects and configurations fd -e csproj | xargs grep -l "xunit" || true fd TestSettings.json || true # Get package info from NuGet curl -s "https://api.nuget.org/v3/registration5-gz-semver2/xunit.runner.visualstudio/index.json" | jq -r '.items[0].items[] | select(.catalogEntry.version | startswith("3.0.")) | .catalogEntry.version,.catalogEntry.description' # Look for any custom test configurations in MSBuild files fd -e props -e targets | xargs grep -l "VSTest" || trueLength of output: 407
Script:
#!/bin/bash # List all files to understand project structure fd . --type f -e csproj -e props -e targets # Find test projects content fd "test" -t f -e csproj | xargs cat || true # Look for xunit configurations fd . -t f -e csproj -e props | xargs grep -i "xunit" || trueLength of output: 2971
Directory.Build.props (1)
19-19: LGTM! Copyright year updated appropriately.The copyright year has been updated to include 2025, which is correct for the upcoming release.
.nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt (1)
1-5: LGTM! Release notes are consistent.The version update and framework support information align with other package updates in this PR.
The same wording improvement suggestion applies here as in the YamlDotNet.App release notes.
🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt (1)
1-2: LGTM! Version and availability information is clear.The version update and framework support are clearly documented.
.docfx/docfx.json (1)
50-50: LGTM! Copyright year is updated correctly.The copyright year update to include 2025 is consistent with the PR objectives.
.nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt (2)
1-2: LGTM! Version and framework support are well documented.The version update and framework compatibility are clearly specified.
4-5: Same wording improvement needed as in AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt.For consistency, apply the same wording improvement here.
🧰 Tools
🪛 LanguageTool
[style] ~5-~5: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...GED Dependencies to latest and greatest with respect to TFMs
Version 9.0.0
Availability: ....(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
CHANGELOG.md (1)
10-13: LGTM! Changelog entry follows the standard format.The entry is well-structured, concise, and follows the Keep a Changelog format. The description accurately reflects the nature of this service update.
.docfx/docfx.json
Outdated
| "filter": "filterConfig.yml", | ||
| "properties": { | ||
| "TargetFramework": "net8.0" | ||
| "TargetFramework": "ne9.0" |
There was a problem hiding this comment.
Fix typo in TargetFramework value.
There's a typo in the framework moniker.
- "TargetFramework": "ne9.0"
+ "TargetFramework": "net9.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "TargetFramework": "ne9.0" | |
| "TargetFramework": "net9.0" |
|
1 participant
This pull request includes several updates across multiple files to upgrade dependencies, update version numbers, and make minor improvements. The most important changes include updating the Docker image version, modifying the target framework, updating package release notes, and adjusting package versions.
Dependency and version updates:
.docfx/Dockerfile.docfx: Updated the base image fromnginx:1.27.0-alpinetonginx:1.27.3-alpine..docfx/docfx.json: Changed theTargetFrameworkproperty fromnet8.0tone9.0.Directory.Packages.props: Updated various package versions to9.0.1and other dependencies to their latest versions.testenvironments.json: Updated the Docker image for theDocker-Ubuntutest environment.Documentation and metadata updates:
Directory.Build.props: Updated the copyright year to include 2025.LICENSE: Updated the copyright year to include 2025.Release notes updates:
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Text.Yaml/PackageReleaseNotes.txt: Added notes for version9.0.1and updated dependencies..nuget/Codebelt.Extensions.AspNetCore.Text.Yaml/PackageReleaseNotes.txt: Added notes for version9.0.1and updated dependencies..nuget/Codebelt.Extensions.YamlDotNet.App/PackageReleaseNotes.txt: Added notes for version9.0.1and updated dependencies..nuget/Codebelt.Extensions.YamlDotNet/PackageReleaseNotes.txt: Added notes for version9.0.1and updated dependencies.CHANGELOG.md: Added a new entry for version9.0.1dated2025-01-29.Summary by CodeRabbit
Release Notes for Version 9.0.1
Package Updates
Documentation
Infrastructure
Chores