Skip to content

No error/warning for incorrect password. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelDesantis opened this issue Mar 6, 2019 · 2 comments
Closed

No error/warning for incorrect password. #55

MichaelDesantis opened this issue Mar 6, 2019 · 2 comments
Assignees
@MichaelDesantis
Labels
bug Something isn't working

Comments

@MichaelDesantis
Copy link
Contributor

MichaelDesantis commented Mar 6, 2019 •
edited
Loading

  • code-server version: 1.31.0
  • OS Version: Mac OS 10.13.6

Steps to Reproduce

  1. Build binary
  2. Run binary
  3. Enter incorrect password

Expected:
Some kind of message saying "password is incorrect"

Actual:
¯\(ツ)/¯
@MichaelDesantis
Copy link
Contributor Author

I can take this one. I've already made mention of it in #51

@MichaelDesantis MichaelDesantis mentioned this issue Mar 6, 2019
Merged
@nhooyr nhooyr added the bug Something isn't working label Mar 8, 2019
MichaelDesantis pushed a commit to MichaelDesantis/code-server that referenced this issue Mar 11, 2019
Add error message for incorrect password. Fix issue coder#55
c7e8d89
@MichaelDesantis MichaelDesantis mentioned this issue Mar 11, 2019
Merged
@MichaelDesantis
Copy link
Contributor Author

UPDATE: PR is here #201

kylecarbs pushed a commit that referenced this issue Mar 12, 2019
@MichaelDesantis @kylecarbs
Add error message for incorrect password. Fix issue #55 (#201)
0efae1f
code-asher pushed a commit that referenced this issue Jun 19, 2019
@MichaelDesantis @kylecarbs
Add error message for incorrect password. Fix issue #55 (#201)
b306e62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelDesantis MichaelDesantis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhooyr @MichaelDesantis