Generate secure passwords, resolves issue #26 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2019
kylecarbs
requested review from
nhooyr
and removed request for
kylecarbs and
code-asher
nhooyr
approved these changes
Mar 6, 2019
MichaelDesantis
force-pushed
the
fix/issue-26
branch
from
9fd1fc2 to
b543880
Compare
MichaelDesantis
changed the title
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#26
Changes:
Swap out the password generator for a native NodeJS CSPRNG method
https://nodejs.org/dist/latest-v10.x/docs/api/crypto.html#crypto_crypto_randombytes_size_callback
Test Environment:
OS: Mac OS High Sierra (10.13.6)
Browser: Google Chrome 72.0.3626.109 (Official Build) (64-bit)
(Result: Pass! Compile was successful and everything functions as expected)
Caveats:
None that I can think of. Although this did lead me to discover another issue. The input component has no error states for an incorrect password. (I'll open a new issue for this and style it to match what we currently have on our hosted services)
UPDATE: other issue is now here #55