Skip to content

Fix GitHub auth #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2020
Merged

Fix GitHub auth #2160

merged 4 commits into from
Dec 18, 2020

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Oct 5, 2020 •
edited
Loading

Closes #1883
Closes #2253

@code-asher code-asher force-pushed the github-auth branch 2 times, most recently from fe9e54a to 9fa6f74 Compare October 5, 2020 22:19
Base automatically changed from vscode-1.49.0 to master October 7, 2020 17:37
@code-asher code-asher force-pushed the github-auth branch 3 times, most recently from efcd501 to a1b67ce Compare December 10, 2020 23:26
@code-asher code-asher added the blocked This issue cannot proceed due to external factors label Dec 10, 2020
@code-asher code-asher removed the blocked This issue cannot proceed due to external factors label Dec 16, 2020
@code-asher code-asher marked this pull request as ready for review December 16, 2020 19:51
@code-asher code-asher requested a review from nhooyr December 16, 2020 19:51
@code-asher code-asher changed the base branch from master to issue-1587-submodule-to-subtree December 16, 2020 21:42
@code-asher
Implement callback endpoints
58c1be5 
VS Code uses these during the authentication flow.
@code-asher
Point to our auth relay
3cc74cc
Base automatically changed from issue-1587-submodule-to-subtree to master December 17, 2020 22:29
nhooyr
nhooyr reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥁

@code-asher
Swap negative check for positive check
d14c2e5
@code-asher
Simplify query concatenation in URL callback
5f7f7f1 
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
nhooyr
nhooyr approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌔

TO THE MOON!!

@code-asher code-asher merged commit f763319 into master Dec 18, 2020
@code-asher code-asher deleted the github-auth branch December 18, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @nhooyr