[conan center] check self.requires.add (and self.build_requires.add)

[SSE4]

original conversation: conan-io/conan-center-index#1293 (comment)

some recipes (may) contain self.requires.add or self.build_requires.add.
these methods aren't currently documented.
they were documented in the past and used across recipes in previous versions of Conan center, but right now they are not part of public API.

/cc @uilianries @jgsogo

[SSE4]

current usage:

./ceres-solver/all/conanfile.py:77:        self.requires.add("eigen/3.3.7")
./ceres-solver/all/conanfile.py:79:            self.requires.add("glog/0.4.0")
./ceres-solver/all/conanfile.py:81:            self.requires.add("gflags/2.2.2")
./ceres-solver/all/conanfile.py:84:            self.requires.add("tbb/2020.0")
./proj/6.x.x/conanfile.py:43:        self.requires.add("sqlite3/3.31.1")
./log4cplus/all/conanfile.py:40:            self.requires.add('libiconv/1.16')
./msgpack/all/conanfile.py:41:            self.requires.add("boost/1.72.0")
./amqp-cpp/all/conanfile.py:48:            self.requires.add("openssl/1.1.1d")
./czmq/all/conanfile.py:46:        self.requires.add("zeromq/4.3.2")
./czmq/all/conanfile.py:50:            self.requires.add("lz4/1.9.2")
./czmq/all/conanfile.py:53:                self.requires.add("libuuid/1.0.3")
./websocketpp/all/conanfile.py:23:        self.requires.add('openssl/1.1.1e')
./websocketpp/all/conanfile.py:24:        self.requires.add('zlib/1.2.11')
./websocketpp/all/conanfile.py:26:            self.requires.add('asio/1.14.0')
./websocketpp/all/conanfile.py:28:            self.requires.add('boost/1.72.0')
./libpng/all/conanfile.py:21:        self.requires.add("zlib/1.2.11")
./hdf4/all/conanfile.py:56:        self.requires.add("zlib/1.2.11")
./hdf4/all/conanfile.py:58:            self.requires.add("libjpeg-turbo/2.0.4")
./hdf4/all/conanfile.py:60:            self.requires.add("libjpeg/9d")
./hdf4/all/conanfile.py:62:            self.requires.add("libaec/1.0.4")
./hdf4/all/conanfile.py:64:            self.requires.add("szip/2.1.1")
./spectra/all/conanfile.py:20:        self.requires.add("eigen/3.3.7")
./freetype/all/conanfile.py:37:            self.requires.add("libpng/1.6.37")
./freetype/all/conanfile.py:39:            self.requires.add("zlib/1.2.11")
./freetype/all/conanfile.py:41:            self.requires.add("bzip2/1.0.8")
./hdf5/all/conanfile.py:69:            self.requires.add("libaec/1.0.4")
./hdf5/all/conanfile.py:71:            self.requires.add("szip/2.1.1")
./zeromq/all/conanfile.py:46:            self.requires.add("libsodium/1.0.18")
./xtensor/all/conanfile.py:56:            self.requires.add("xsimd/7.4.6")
./xtensor/all/conanfile.py:58:            self.requires.add("tbb/2020.0")
./libarchive/all/conanfile.py:73:        self.requires.add("zlib/1.2.11")
./libarchive/all/conanfile.py:75:            self.requires.add("bzip2/1.0.8")
./libarchive/all/conanfile.py:77:            self.requires.add("openssl/1.1.1d")
./libarchive/all/conanfile.py:79:            self.requires.add("lz4/1.9.2")
./libarchive/all/conanfile.py:81:            self.requires.add("zstd/1.4.3")
./libarchive/all/conanfile.py:85:            self.requires.add("libxml2/2.9.9")
./libarchive/all/conanfile.py:87:            self.requires.add("expat/2.2.7")
./libcurl/all/conanfile.py:114:                self.requires.add("openssl/1.1.1f")
./libcurl/all/conanfile.py:117:                self.requires.add("libssh2/1.9.0")
./libcurl/all/conanfile.py:119:            self.requires.add("libnghttp2/1.40.0")
./libcurl/all/conanfile.py:121:        self.requires.add("zlib/1.2.11")
./mysql-connector-c/all/conanfile.py:23:            self.requires.add("openssl/1.0.2u")
./mysql-connector-c/all/conanfile.py:26:            self.requires.add("zlib/1.2.11")
./libnghttp2/all/conanfile.py:46:        self.requires.add("zlib/1.2.11")
./libnghttp2/all/conanfile.py:48:            self.requires.add("openssl/1.1.1d")
./libnghttp2/all/conanfile.py:49:            self.requires.add("c-ares/1.15.0")
./libnghttp2/all/conanfile.py:50:            self.requires.add("libev/4.27")
./libnghttp2/all/conanfile.py:51:            self.requires.add("libevent/2.1.11")
./libnghttp2/all/conanfile.py:52:            self.requires.add("libxml2/2.9.9")
./libnghttp2/all/conanfile.py:54:            self.requires.add("jansson/2.12")
./libnghttp2/all/conanfile.py:56:            self.requires.add("jemalloc/5.2.1")
./libnghttp2/all/conanfile.py:58:            self.requires.add("boost/1.71.0")
./libssh2/all/conanfile.py:50:            self.requires.add("zlib/1.2.11")
./libssh2/all/conanfile.py:52:            self.requires.add("openssl/1.1.1d")
./libssh2/all/conanfile.py:54:            self.requires.add("mbedtls/2.16.3-gpl")
./c-blosc/all/conanfile.py:56:            self.requires.add("lz4/1.9.2")
./c-blosc/all/conanfile.py:58:            self.requires.add("snappy/1.1.8")
./c-blosc/all/conanfile.py:60:            self.requires.add("zlib/1.2.11")
./c-blosc/all/conanfile.py:62:            self.requires.add("zstd/1.4.4")
./cfitsio/all/conanfile.py:58:        self.requires.add("zlib/1.2.11")
./cfitsio/all/conanfile.py:61:            self.requires.add("pthreads4w/3.0.0")
./cfitsio/all/conanfile.py:63:            self.requires.add("bzip2/1.0.8")
./cfitsio/all/conanfile.py:65:            self.requires.add("libcurl/7.68.0")
./libpq/all/conanfile.py:51:            self.requires.add("zlib/1.2.11")
./libpq/all/conanfile.py:53:            self.requires.add("openssl/1.0.2s")
./libmysqlclient/all/conanfile.py:24:            self.requires.add("openssl/1.1.1d")
./libmysqlclient/all/conanfile.py:27:            self.requires.add("zlib/1.2.11")
./pcre2/all/conanfile.py:45:            self.requires.add("bzip2/1.0.8")
./libevent/2.1.11/conanfile.py:40:            self.requires.add("openssl/1.1.1d")
./libkml/all/conanfile.py:33:        self.requires.add("boost/1.72.0")
./libkml/all/conanfile.py:34:        self.requires.add("expat/2.2.9")
./libkml/all/conanfile.py:35:        self.requires.add("minizip/1.2.11")
./libkml/all/conanfile.py:36:        self.requires.add("uriparser/0.9.3")
./libkml/all/conanfile.py:37:        self.requires.add("zlib/1.2.11")
./leptonica/all/conanfile.py:39:        self.requires.add("zlib/1.2.11")
./leptonica/all/conanfile.py:41:            self.requires.add("giflib/5.1.4")
./leptonica/all/conanfile.py:43:            self.requires.add("libjpeg/9d")
./leptonica/all/conanfile.py:45:            self.requires.add("libpng/1.6.37")
./leptonica/all/conanfile.py:47:            self.requires.add("libtiff/4.1.0")
./leptonica/all/conanfile.py:49:            self.requires.add("openjpeg/2.3.1")
./leptonica/all/conanfile.py:51:            self.requires.add("libwebp/1.0.3")
./pcre/all/conanfile.py:56:            self.requires.add("bzip2/1.0.8")
./pcre/all/conanfile.py:58:            self.requires.add("zlib/1.2.11")
./ixwebsocket/all/conanfile.py:62:            self.requires.add("openssl/1.1.1c")
./ixwebsocket/all/conanfile.py:64:        self.requires.add("zlib/1.2.11")
./ixwebsocket/all/conanfile.py:67:            self.requires.add("mbedtls/2.16.3-apache")
./cpp-httplib/all/conanfile.py:25:            self.requires.add("openssl/1.1.1d")
./cpp-httplib/all/conanfile.py:27:            self.requires.add("zlib/1.2.11")
./jasper/all/conanfile.py:33:            self.requires.add("libjpeg-turbo/2.0.4")
./jasper/all/conanfile.py:35:            self.requires.add("libjpeg/9d")
./poco/all/conanfile.py:110:            self.requires.add("openssl/1.0.2t")

./nasm/ALL/conanfile.py:28:            self.build_requires.add("strawberryperl/5.30.0.1")

[memsharded]

requires no big deal, but if some is using build_requires it is probably broken right now, because build_requires.add() interface changed. Could you please check the usage of build_requires.add()?

@jgsogo should we introduce a default for it in 1.24.1?

[jgsogo]

We should fix nasm asap (it is only a conditional build_requires)

self.requires.add, not so urgent, still works, but we should pay attention and start fixing those recipes.

No, there is no need for a default after almost a month. There has been only one issue related to this change (conan-io/conan#6667).

Thanks @SSE4 for finding all the usages 🙌