#175 Do not allow requires.add (KB-H044) #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
SSE4
approved these changes
Apr 14, 2020
Signed-off-by: Uilian Ries <[email protected]>
jgsogo
approved these changes
Apr 28, 2020
danimtb
approved these changes
May 4, 2020
|
Updated conan-center-index wiki. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #175
Wiki:
#KB-H044: "NO REQUIRES.ADD()"
Both
self.requires.add()andself.build_requires.add()have been deprecated in favor ofself.requires()andself.build_requires()which were introduced on Conan 1.x. Bothadd()were introduced during Conan 0.x and since Conan 1.23 they no longer follow the original behavior.