Skip to content

Handle variants for transitive subpackage resolution#5651

Merged
beckermr merged 14 commits intoconda:25.3.xfrom
isuruf:variants
Mar 29, 2025
Merged

Handle variants for transitive subpackage resolution#5651
beckermr merged 14 commits intoconda:25.3.xfrom
isuruf:variants

Conversation

@isuruf
Copy link
Copy Markdown
Contributor

@isuruf isuruf commented Mar 24, 2025

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@isuruf isuruf requested a review from a team as a code owner March 24, 2025 12:34
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Mar 24, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 24, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 24, 2025

CodSpeed Performance Report

Merging #5651 will not alter performance

Comparing isuruf:variants (ae4423a) with 25.3.x (d49d2f2)

Summary

✅ 5 untouched benchmarks

Comment thread conda_build/render.py
Comment thread conda_build/render.py
isuruf and others added 2 commits March 24, 2025 08:23
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@beckermr
Copy link
Copy Markdown
Contributor

Looks like one of the regression tests that run only on osx failed. We'll have to fix that before we can merge.

@isuruf isuruf requested review from a team, beckermr and jaimergp March 25, 2025 16:28
@beckermr
Copy link
Copy Markdown
Contributor

The test failures here appear unrelated but also persistent.

I'm definitely getting frustrated with the test suite.

@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

beckermr
beckermr previously approved these changes Mar 29, 2025
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Mar 29, 2025
@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

@beckermr beckermr merged commit 2865675 into conda:25.3.x Mar 29, 2025
28 checks passed
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Mar 29, 2025
@github-actions github-actions Bot added the locked [bot] locked due to inactivity label Mar 30, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants