Revert "Fix transitive subpackage dependency resolution (#5603)"#5647
Merged
Revert "Fix transitive subpackage dependency resolution (#5603)"#5647
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.0](astral-sh/ruff-pre-commit@v0.9.10...v0.11.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merge `25.3.x` back into `main`
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5647 will not alter performanceComparing Summary
|
beckermr
requested changes
Mar 21, 2025
Contributor
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
Let's leave the test and mark it as xfail.
This reverts commit 49872a5, but keeping tests
jaimergp
force-pushed
the
revert-5603-transitive-subpackage
branch
from
f4e9170 to
66ccb2a
Compare
beckermr
previously approved these changes
Mar 21, 2025
kenodegard
previously approved these changes
Mar 21, 2025
Contributor
|
Another test to xfail? |
isuruf
approved these changes
Mar 22, 2025
Contributor
|
I've added regression tests for this issue in this PR: #5648 |
isuruf
added a commit
to isuruf/conda-build
that referenced
this pull request
Mar 24, 2025
conda#5647) This reverts commit 19251f4.
kenodegard
added a commit
that referenced
this pull request
Mar 24, 2025
* Downgrade necessary permissions for build script * Use atomic moves to minimize attack window * add news * minimize windows further * use opener * Provide new helper context manager to handle atomic writes and permission setting * pre-commit * clarify need for umask reset * use secrets.token_urlsafe with 64 characters * Revert "Fix transitive subpackage dependency resolution (#5603)" (#5647) * Update conda_build/utils.py Co-authored-by: Ken Odegard <kodegard@anaconda.com> * Update conda_build/utils.py --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stopgap for #5644 and #5645
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?