test: regression tests for bugs in 5645 and 5644#5648
Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.0](astral-sh/ruff-pre-commit@v0.9.10...v0.11.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merge `25.3.x` back into `main`
This reverts commit 49872a5, but keeping tests
CodSpeed Performance ReportMerging #5648 will not alter performanceComparing Summary
|
Contributor
Author
|
@conda/builds-tools This PR is ready for review! |
3 tasks
Contributor
|
Thanks |
Contributor
Author
|
If you approve the pr @isuruf, we can merge and then check your fix against the new tests. |
isuruf
approved these changes
Mar 24, 2025
Contributor
|
Ah, that's what github was waiting for |
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test for the regressions reported in #5645 and #5644.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Extra items
The test failures in #5649 are:
This is the correct failure due to the conflicting python specs.
The other test failure for #5644 that I get locally looks correct too:
This looks correct relative to the original issue, but is for a different python version which is fine. I will check back on the CI version in a bit to ensure that works as well.
Yep the test failure is correct: