properly include pep725 optional dependencies#612
Merged
marcelotrevisani merged 1 commit intoconda:mainfrom Apr 15, 2025
Merged
properly include pep725 optional dependencies#612marcelotrevisani merged 1 commit intoconda:mainfrom
marcelotrevisani merged 1 commit intoconda:mainfrom
Conversation
5 tasks
marcelotrevisani
approved these changes
Apr 15, 2025
Member
|
Thank you for your contribution, lgtm! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 5, 2025
sagemathgh-39944: Include optional packages in `pyproject.toml` and conda environments <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Adds the missing information about optional dependencies in the `pyproject.toml` and use this updated info to include these packages also in the conda environment. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - (Upstream conda/grayskull#612) - conda-forge/cypari2-feedstock#57 URL: sagemath#39944 Reported by: Tobias Diez Reviewer(s): Isuru Fernando
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the code looked for the
optional-dependenciesgroup in the root ofpyproject.toml. This is fixed to correctly use theexternalssection. Moreover, the optional deps purls are correctly mapped to the conda package.Finally, the purl - conda package map is slightly expanded.