Include optional packages in pyproject.toml and conda environments#39944
Merged
vbraun merged 8 commits intosagemath:developfrom Jul 6, 2025
Merged
Include optional packages in pyproject.toml and conda environments#39944vbraun merged 8 commits intosagemath:developfrom
pyproject.toml and conda environments#39944vbraun merged 8 commits intosagemath:developfrom
Conversation
5 tasks
|
Documentation preview for this PR (built with commit b2a67f4; changes) is ready! 🎉 |
isuruf
approved these changes
Apr 28, 2025
Contributor
Author
|
Sorry, this is not yet quiet ready. There are a bunch of failing tests. Didn't yet have the time to investigate where the are coming from. |
Contributor
Author
|
@isuruf This is now ready for review (the failing tests are just the usual, known random failures) |
Contributor
Author
|
@isuruf I'm setting this now to positive review based on your previous review. Please let me know if that's not okay with you or if you have any further remarks/suggestions for improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing information about optional dependencies in the
pyproject.tomland use this updated info to include these packages also in the conda environment.📝 Checklist
⌛ Dependencies