-
Notifications
You must be signed in to change notification settings - Fork 14
refactor multi-arch-packaging promotion to run on single agent #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he prerelease process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the multi-arch packaging promotion pipeline to consolidate multiple separate agent jobs into a single agent with parallelized matrix jobs, improving packaging efficiency by eliminating agent spin-up wait times.
Key changes:
- Consolidated 5 separate agent blocks into 1 block with matrix-based parallelization
- Simplified the dependency structure for the upload job
- Unified command structure across all platforms using case statements
jobs: | ||
- name: "Upload VSIX files to GitHub" | ||
commands: | ||
- artifact pull workflow packaged-vsix-files/ | ||
- make upload-vsix-files-to-gh-releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: see if we can merge this and https://github.com/confluentinc/vscode/blob/main/.semaphore/prerelease-multi-arch-packaging.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the configs here between the prerelease pipeline and this one vary more than I thought, so I'm inclined to punt merging them to a future branch after we know this is working as expected.
Thanks, yay much simpler, stabler, faster, cheaper. |
Just like https://github.com/confluentinc/vscode/blob/main/.semaphore/prerelease-multi-arch-packaging.yml, consolidate to a single agent with parallelized jobs based on our supported targets, which speeds up overall packaging time since we don't need to wait for different agents to spin up:

https://semaphore.ci.confluent.io/workflows/4a9fb6ee-eb83-47be-b1d4-e54f75295fe4/artifacts?path=packaged-vsix-files
Closes #1282