feat: add support for "none" scope #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
+ Coverage 69.23% 69.42% +0.19%
==========================================
Files 26 26
Lines 2467 2473 +6
==========================================
+ Hits 1708 1717 +9
+ Misses 661 659 -2
+ Partials 98 97 -1
☔ View full report in Codecov by Sentry. |
piksel
force-pushed
the
feat/none-scope
branch
from
ba2df7d to
e539199
Compare
|
Thanks for this feature! I am noticing that on a restart of my watchtower with scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special "none" scope to watchtower that matches containers without a scope label, a scope label set to
none, or a scope label set to an empty string (com.centurylinklabs.watchtower.scope=).Effectively, this enables you to run both scoped and unscoped version of watchtower simultaneously.
Fixes #1788
Fixes #1541