configure shellcheck, golang lint for COSA#359
Merged
Conversation
Similar to our other conditionals for opting out of go_lint, go_mod etc.
Right now in the COSA repo we have a bespoke shellcheck setup that doesn't match our other repos. Let's start using repo-templates for it too.
The existing workflows in the COSA repo [1] run the lints and we want to convert to using repo-templates here. [1] https://github.com/coreos/coreos-assembler/blob/e83ab4d4a135b630dcbd17e1d8e13c8c55e01b1f/.github/workflows/lints.yml
prestist
approved these changes
Mar 4, 2026
prestist
left a comment
prestist
left a comment
Contributor
There was a problem hiding this comment.
Ah nice, yeah these changes look good. I don't see anything that stands out as needing to change.
LGTM
dustymabe
added a commit
to coreosbot-releng/coreos-assembler
that referenced
this pull request
Mar 4, 2026
We'll now use the ci/shellcheck from the repo-templates since we enabled syncing it for COSA in [1]. [1] coreos/repo-templates#359
dustymabe
added a commit
to coreosbot-releng/coreos-assembler
that referenced
this pull request
Mar 4, 2026
We're now using the go shellcheck workflows from repo-templates [1] so we can drop this custom workflow in this repo. [1] coreos/repo-templates#359
dustymabe
added a commit
to coreosbot-releng/coreos-assembler
that referenced
this pull request
Mar 6, 2026
We'll now use the ci/shellcheck from the repo-templates since we enabled syncing it for COSA in [1]. [1] coreos/repo-templates#359
dustymabe
added a commit
to coreosbot-releng/coreos-assembler
that referenced
this pull request
Mar 6, 2026
We're now using the go shellcheck workflows from repo-templates [1] so we can drop this custom workflow in this repo. [1] coreos/repo-templates#359
dustymabe
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Mar 6, 2026
We'll now use the ci/shellcheck from the repo-templates since we enabled syncing it for COSA in [1]. [1] coreos/repo-templates#359
dustymabe
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Mar 6, 2026
We're now using the go shellcheck workflows from repo-templates [1] so we can drop this custom workflow in this repo. [1] coreos/repo-templates#359
dustymabe
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Mar 18, 2026
In [1] we configured repo-templates to push the go and shellcheck workflows to the COSA repo. Right now the existing golangci-lint workflow here is failing because of golang versions. Let's just drop the existing lints here prematurely knowing that we are going to move to the new repo-templates provided linters in [2]. [1] coreos/repo-templates#359 [2] coreos#4468
dustymabe
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 18, 2026
In [1] we configured repo-templates to push the go and shellcheck workflows to the COSA repo. Right now the existing golangci-lint workflow here is failing because of golang versions. Let's just drop the existing lints here prematurely knowing that we are going to move to the new repo-templates provided linters in [2]. [1] coreos/repo-templates#359 [2] #4468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.