Skip to content

configure shellcheck, golang lint for COSA #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustymabe merged 3 commits into from
Mar 4, 2026
+22 −0
Merged

configure shellcheck, golang lint for COSA #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d1137e
go/tests: add ability to opt out of running go test
dustymabe Mar 4, 2026
8475842
shellcheck: enable for coreos-assembler repo
dustymabe Mar 4, 2026
1d8f604
go/tests: configure to run lints against COSA
dustymabe Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions go/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
vars:
do_go_lint: true
do_go_mod: true
do_go_test: true
# go_versions defined in ../config.yaml
golangci_lint_version: v2.6.2
go_build_cmd: go build
Expand Down Expand Up @@ -82,3 +83,11 @@ files:
vars:
go_build_cmd: ~
go_test_cmd: ./test

# Run just the lints on COSA
- repo: coreos-assembler
path: .github/workflows/go.yml
vars:
go_build_cmd: ~
do_go_test: false
do_go_mod: false
2 changes: 2 additions & 0 deletions go/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,13 @@ jobs:
{%- endif %}
run: {{ go_build_cmd }}
{%- endif %}
{%- if do_go_test %}
- name: Test
{%- if do_multi_os %}
shell: bash
{%- endif %}
run: {{ go_test_cmd }}
{%- endif %}
{%- if do_go_lint %}
- name: Check Go formatting (gofmt)
{%- if do_multi_os %}
Expand Down
3 changes: 3 additions & 0 deletions shellcheck/script.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ files:

- repo: toolbox
path: ci/shellcheck

- repo: coreos-assembler
path: ci/shellcheck
8 changes: 8 additions & 0 deletions shellcheck/workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,11 @@ files:
vars:
branches:
- main

- repo: coreos-assembler
path: .github/workflows/shellcheck.yml
vars:
branches:
- main
- rhel-*
- rhcos-*