Split variable adder and constrain variable passes #446
Conversation
| @@ -199,10 +203,6 @@ class ProgramInfo : public ProgramVariableAdder { | |||
| // Retrieves a FVConstraint* from a Decl (which could be static, or global) | |||
| FVConstraint *getFuncFVConstraint(FunctionDecl *FD, ASTContext *C); | |||
|
|
|||
| // For each pointer type in the declaration of D, add a variable to the | |||
| // constraint system for that pointer type. | |||
| void addVariable(clang::DeclaratorDecl *D, clang::ASTContext *AstContext); | |||
There was a problem hiding this comment.
This was originally made private so that it could be exposed by the ProgramVariableAdder interface used by VariableAdderVisitor. The idea was that only VariableAdderVisitor should be creating variables, so restricting access to this function makes it less likely that variables are added elsewhere.
It looks like you made this change because you need seenTypedef and addTypedef, so I suggest adding these functions to ProgramVariableAdder and keeping addVariable private.
There was a problem hiding this comment.
Right, I forgot to ask about this. It looks like we have multiple interfaces, but only use one class. But this seems like a decent explanation so I'll follow your suggestion unless I hear otherwise.
|
This PR was intended to solve an immediate benchmark issue, but didn't get to run on the benchmarks until a more encompassing code change was produced (#463). The valuable parts have been incorporated into that change. |
By creating and merging all FV's at once, we avoid alterations introduced by the constraints on them. Merging is simpler and solves #427. Hopefully, this allows us to remove code later that dealing with the complexity, like the various brainTransplant methods.
The Typedef map needed to be populated in the variable adder stage, or it wasn't available in time.