Skip to content

Skip cast insertion in unwritable files with a warning. #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

Skip cast insertion in unwritable files with a warning. #455

merged 1 commit into from
Feb 26, 2021

Conversation

mattmccutchen-cci
Copy link
Member

See #454.

Unblocks the Windows tests from #449 (and may unblock #446 from #423: not tested).

john-h-kastner
john-h-kastner approved these changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@john-h-kastner john-h-kastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mattmccutchen-cci mattmccutchen-cci merged commit 1b8b690 into main Feb 26, 2021
@mattmccutchen-cci mattmccutchen-cci deleted the cast-unwritable branch February 26, 2021 18:43
@kyleheadley kyleheadley mentioned this pull request Mar 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-h-kastner john-h-kastner john-h-kastner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmccutchen-cci @john-h-kastner