Skip to content

Major refactor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 63 commits into from
Closed

Major refactor #6

wants to merge 63 commits into from

Conversation

Machiry
Copy link
Collaborator

@Machiry Machiry commented Jun 24, 2019 •
edited
Loading

This is a major refactoring of the current implementation.
Following are the major changes in this pull request:

  1. Correct handling of in-scope and external constraint variables: There were many places where this was not handled correctly. Furthermore, the behavior of the current implementation depends a lot on whether a declaration exists for a function or not, However, this should not be the case, irrespective of whether the declaration exists or not, we should have the same behavior. I have implemented this by creating a dummy constraint variables when a declaration doesn't exist for a function (This is also what Dr. Hicks suggested).
  2. Modularizing code: There were several places where the same code was repeated multiple times and I have created functions for the duplicated code.
  3. Functionality Tests: Although we have unit tests, there are no functionality tests. I have added several functionality tests and a simple script to verify them.
  4. Minor stuff: JSON output, making the merging of multiple declarations optional.

If you think it will make it easy, we can schedule a meeting and I can explain my changes which could give you more context to review the changes.

Pointer detection improvement (on IceCast): Ptr: 27%, NtArr: 87%, Arr: 93%

rchyena and others added 30 commits June 4, 2019 23:20
@rchyena
Update DeclStmt to Stmt inside DAndReplace
43051e6 
This change allows for all statements to bubble up through the
analysis engine, not just declaration statements.
@rchyena
Add comments to output for array pointers.
22a1cd3 
Comments will appear at the end of the line in which they are defined.

NOTE: The Checked C type rewriting pass must occur first.  Otherwise,
it may overwrite any changes added during prior rewriting passes.
@Machiry
Refectoring Utils and ConstraintVariables
a17cf58
@Machiry
Minor edits
1eb2c0c
@Machiry
Merge pull request #1 from Machiry/arr_ptr
2bc726c 
Merging to master
@Machiry
Finishing up refactoring
ed23ffa
@Machiry
initial template
3062366
@Machiry
Initial prototype
4d5e7d5
@Machiry
Minor fixes
2f62258
@Machiry
Fixing minor
0d6a6f2
@Machiry
Fixing the void * issue
736b0d1
@Machiry
Adding NT Array contraint type
57472e7
@Machiry
Finalizing NT_array detection
3b14f74
@Machiry
Minor refactoring
539b7ca
@Machiry
Adidng unit tests
4e344b4
@Machiry
Minor fixes
b998f5d
@Machiry
Minor refactoring and fixed unit tests
eb3d503
@Machiry
Modified lattice
987110a
@Machiry
Clean up and refactoring
5d39407
@Machiry
Finalizing NT array implementation
e7f5bd8
@Machiry
Merge branch 'master' into debuggingNT
86c919d 
Merging into master after debugging NT issue.
@Machiry
Merge pull request #2 from Machiry/debuggingNT
f782fa0 
Debugging nt
@Machiry
Refactoring
2bff6eb
@Machiry
Added to json methods
4d4c4d5
@Machiry
Minor fix
a781b9f
@Machiry
Adding dump to json functionality
25c25bb
@Machiry
WIP/getVariable
772fc2c
@Machiry
WIP/Fixed constraint generation of CallExpression
5ce5a7f
@Machiry
Fixing Adding equality constraints
42693cf
@Machiry
Fixing local assignement'
c220c98 
'
Machiry and others added 23 commits June 24, 2019 22:30
@Machiry
Minor fir for handling function pointers
b06f1b1
@Machiry
Fixed the addition of storage qualifiers (i.e., static and extern)
1bca902
@Machiry
Handling passing of functions as variables (for function pointers)
ec19850
@Machiry
Fixing handling of compiler args
2517d84
@Machiry
Removing unnecessary debug output
0312dcc
@Machiry
Minor
73b8199
@Machiry
Merge branch 'major_refactor' of github.com:plum-umd/checkedc-clang i…
c3e6578 
…nto major_refactor
@Machiry
Ensuring function declaration to be used for all CallExpressions and …
999330a 
…FunctionDecl. However, using function definition only for return values
@Machiry
Merge branch 'major_refactor' of github.com:plum-umd/checkedc-clang i…
084f910 
…nto major_refactor
@Machiry
Avoid Rewriting function return type, if it was handled by cast rewri…
68d4c11 
…te visitor
@Machiry
Using absolute paths for files - this is needed to consistently displ…
5f8c2f0 
…ay the stats
@Machiry
Handling NULL assignment, fixing rewriter, fixing duplicate constrain…
b03af46 
…t variables=
@Machiry
Adding base_dir argument to be passed to the tool
cdadea2
@Machiry
Fixing script to produce valid checked-c-convert commands
837be11
@Machiry
Fixing minor regression
57e2e1a
@Machiry
Ensuring that we do not make an itype constraint variable to be WILD
0141a69
@Machiry
Small and cute constraint debugger
c3bdbb8
@Machiry
Flag to enable handling of varargs
f76d88f
@Machiry
Ignoring varargs and handling of itypes, Huge Improvement (Ptr: 27%, …
11f061c 
…NtArr: 87%, Arr: 93%)
@Machiry
Removing unused variables
d5f8778
@Machiry
Fixing missing * in the return type during itype
97662d5
@Machiry
Adding correct type
a9cf209
@Machiry
Adding correct NT array type
2e4436a
@Machiry
Copy link
Collaborator Author

Machiry commented Jul 10, 2019

We also fixed:

checkedc#622

@rchyena
Copy link

rchyena commented Jul 27, 2019

We incorporated these commits through PR #642 on Microsoft's repo.

@rchyena rchyena closed this Jul 27, 2019
@Machiry Machiry deleted the major_refactor branch August 30, 2019 19:49
Machiry pushed a commit that referenced this pull request May 17, 2020
@jasonmolenda
Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str.
be4be61 
If a core file has an EFI version string which includes a UUID
(similar to what it returns for the kdp KDP_KERNELVERSION packet)
in the LC_IDENT or LC_NOTE 'kern ver str' load command.  In that
case, we should try to find the binary and dSYM for the UUID
listed.  The dSYM may have python code which knows how to relocate
the binary to the correct address in lldb's target section load
list and loads other ancillary binaries.

The test case is a little involved,

1. it compiles an inferior hello world apple (a.out),
2. it compiles a program which can create a corefile manually
   with a specific binary's UUID encoded in it,
3. it gets the UUID of the a.out binary,
4. it creates a shell script, dsym-for-uuid.sh, which will
   return the full path to the a.out + a.out.dSYM when called
   with teh correct UUID,
5. it sets the LLDB_APPLE_DSYMFORUUID_EXECUTABLE env var before
   creating the lldb target, to point to this dsym-for-uuid.sh,
6. runs the create-corefile binary we compiled in step #2,
7. loads the corefile from step #6 into lldb,
8. verifies that lldb loaded a.out by reading the LC_NOTE
   load command from the corefile, calling dsym-for-uuid.sh with
   that UUID, got back the path to a.out and loaded it.

whew!

<rdar://problem/47562911>

llvm-svn: 366378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Machiry Machiry

@rchyena rchyena

@hasantouma hasantouma

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Machiry @rchyena @hasantouma