-
Notifications
You must be signed in to change notification settings - Fork 816
Use a Retryer instead of retry loops for DynamoDB #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There's a chance I can take this on, depending on our priorities. It seems like the logic in the DefaultRetryer from the AWS SDK should work, if wrapped with monitoring code. Would that be sufficient? Or do you envision some custom retry logic? |
I believe the intention is to just wrap with monitoring code and stop trying to do any custom retry logic. |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I believe all of
|
Chunks storage was removed. |
The DynamoDB client disables retries and then wraps everything in a loop to do retries.
Disabling retries came in #153; the backoff loop has gone through many iterations since #119.
The stated reason is that we want to monitor retries.
From my experiences using the DynamoDB API elsewhere, I think it would be far cleaner to implement a
Retryer
which adds the required monitoring, let the AWS SDK do retries, and take out the explicit loops.Noted at #792 (comment).
The text was updated successfully, but these errors were encountered: